-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Test updates for central sanitizers #35385
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
App Configuration
Azure.ApplicationModel.Configuration
App Configuration Provider
Cognitive - Form Recognizer
Cognitive - Language
Cognitive - Text Analytics
Cognitive - Translator
Communication
Communication - Phone Numbers
Communication - Rooms
Communication - Job Router
Container Registry
Document Intelligence
KeyVault
Tables
labels
Apr 26, 2024
API change check API changes are not detected in this pull request. |
pvaneck
force-pushed
the
test-proxy-sanitizer-update
branch
4 times, most recently
from
May 3, 2024 20:56
9549512
to
9492e67
Compare
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
pvaneck
force-pushed
the
test-proxy-sanitizer-update
branch
from
May 6, 2024 22:44
b161508
to
4fd4360
Compare
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
pvaneck
requested review from
needuv,
ninghu,
YusakuNo1,
tomsft,
miguhern,
whisper6284,
RoyHerrod,
danielav7,
sarkar-rajarshi,
albertofori,
avanigupta,
mrm9084,
annatisch,
jalauzon-msft,
vincenttran-msft,
weirongw23-msft,
lmazuel,
johanste,
xiangyan99,
iscai-msft and
kashifkhan
as code owners
May 7, 2024 02:02
xiangyan99
approved these changes
May 7, 2024
mccoyp
reviewed
May 7, 2024
mccoyp
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this work!
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
App Configuration Provider
App Configuration
Azure.ApplicationModel.Configuration
Cognitive - Form Recognizer
Cognitive - Language
Cognitive - Text Analytics
Cognitive - Translator
Communication - Job Router
Communication - Phone Numbers
Communication - Rooms
Communication
Container Registry
Document Intelligence
KeyVault
Tables
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our Python testing framework to adopt the new TestProxy which enables numerous common sanitizers.
Since these new common sanitizers might be considered too aggressive in some cases, a new API was added to
devtools_testutils
to remove specific sanitizers:remove_batch_sanitizers
. With this new method, SDK owners can opt out of certain sanitizers by passing in a list of sanitizer IDs toremove_batch_sanitizers
in theirconftest.py
files. For example:The list of sanitizers and their IDs can be viewed here. When a sanitizer is opted out of, it's important to be sure that the non-sanitized data is non-sensitive.
Other changes in this PR:
set_common_sanitizers
method since these are applied by TestProxy itself.generate_sas
function since TestProxy sanitizers will handle sanitization ofse
,st
, andsig
URI query parameters. Tests and recordinings using this function should not break with this PR.assets.json
files.add_sanitizer
methods were updated to be session-scoped improving, massively improving testing performance.