Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create disk with ConfidentialVM_NonPersistedTPM securityType #36161

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fnerdman
Copy link

@fnerdman fnerdman commented Jun 19, 2024

Description

Adds option to create managed disks with ConfidentialVM_NonPersistedTPM securityType. These are required to boot ConfidentialVMs with --os-disk-security-encryption-type set to NonPersistedTPM.

This is more of an issue rather than a PR. The patch fixes deployment on my side, but I won't add changelog and test cases. So this could be used as a precursor to the final PR.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Adds option to create managed disks with ConfidentialVM_NonPersistedTPM securityType. These are required to boot ConfidentialVMs with `--os-disk-security-encryption-type` set to `NonPersistedTPM`
@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Jun 19, 2024
Copy link

Thank you for your contribution @fnerdman! We will review the pull request and get back to you soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant