Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR web/resource-manager] Add Managed Identity envelope to SitePatchResource #4768

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

AutorestCI
Copy link
Contributor

Add Managed Identity envelope to SitePatchResource

Add Managed Identity envelope to SitePatchResource object to allow PATCH identity operations to a site through Swagger
@AutorestCI
Copy link
Contributor Author

AutorestCI commented Apr 3, 2019

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-web

You can install the package azure-mgmt-web of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_5542#egg=azure-mgmt-web&subdirectory=azure-mgmt-web"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_5542#egg=azure-mgmt-web&subdirectory=azure-mgmt-web"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_5542
  • pip install -e ./azure-mgmt-web

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_5542
  • pip wheel --no-deps ./azure-mgmt-web

Direct download

Your files can be directly downloaded here:

@codecov-io
Copy link

Codecov Report

Merging #4768 into restapi_auto_web/resource-manager will increase coverage by 0.83%.
The diff coverage is 33.33%.

Impacted file tree graph

@@                          Coverage Diff                          @@
##           restapi_auto_web/resource-manager    #4768      +/-   ##
=====================================================================
+ Coverage                              52.54%   53.37%   +0.83%     
=====================================================================
  Files                                  11095    10470     -625     
  Lines                                 241235   219617   -21618     
=====================================================================
- Hits                                  126756   117222    -9534     
+ Misses                                114479   102395   -12084
Impacted Files Coverage Δ
...t-web/azure/mgmt/web/models/site_patch_resource.py 11.36% <0%> (-0.27%) ⬇️
...b/azure/mgmt/web/models/site_patch_resource_py3.py 11.36% <50%> (-0.27%) ⬇️
...ion/face/models/name_and_user_data_contract_py3.py 62.5% <0%> (-37.5%) ⬇️
...edia/azure/mgmt/media/models/job_input_clip_py3.py 60% <0%> (-11.43%) ⬇️
.../azure/mgmt/monitor/models/metric_dimension_py3.py 55.55% <0%> (-11.12%) ⬇️
...e/mgmt/monitor/models/metric_alert_criteria_py3.py 66.66% <0%> (-10.26%) ⬇️
...dia/azure/mgmt/media/models/job_input_asset_py3.py 62.5% <0%> (-10.23%) ⬇️
...dia/models/built_in_standard_encoder_preset_py3.py 62.5% <0%> (-10.23%) ⬇️
...-mgmt-media/azure/mgmt/media/models/overlay_py3.py 42.85% <0%> (-10.09%) ⬇️
...t-media/azure/mgmt/media/models/video_layer_py3.py 42.85% <0%> (-9.78%) ⬇️
... and 740 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b8b822...7634a5c. Read the comment docs.

@AutorestCI AutorestCI merged commit c8c4bbd into restapi_auto_web/resource-manager Apr 3, 2019
@AutorestCI AutorestCI deleted the restapi_auto_5542 branch April 3, 2019 19:54
@AutorestCI
Copy link
Contributor Author

This PR has been merged into #4429

lmazuel pushed a commit that referenced this pull request May 24, 2019
* Generated from b358cc2d9448ec292d6d67de69f587080731c85e (#4428)

Add examples of 201 response to AppServicePlans_CreateOrUpdate.

* Generated from c2d7ae74564edf027d2baa5d39864ba26a4f593a (#4448)

Update UserAssignedIdentities spec in Web

Microsoft.Web recently added support for UserAssigned managed service identities (in preview), but the swagger spec is incorrect for the identity payload as it follows the old construct of sending an array of identityIds as opposed to the updated spec which instead sends a dictionary object called userAssignedIdentities. 

Spec + history outlined here:
http://sharepoint/sites/AzureUX/Sparta/_layouts/15/WopiFrame2.aspx?sourcedoc=%7b633632B4-02E4-4DE2-92A9-EDCAF9BE73D4%7d&file=ARM%2BMSI.docx&action=default 

Our swagger contains identityids[] because of previous work to future support UserAssigned identities, but never released the feature in that state, rather we opted to wait for the new spec to be supported and then integrated with that on our end. 

Our MSI implementation reflects Microsoft.Compute's spec for user assigned.

https://github.com/Azure/azure-rest-api-specs/blob/78e1feab142c605839aa3cec23442ca26b8ef04d/specification/compute/resource-manager/Microsoft.Compute/stable/2018-06-01/compute.json

* Packaging update of azure-mgmt-web

* [AutoPR web/resource-manager] [Hub Generated] Review request for Microsoft.Web to add version 2018-02-01 (#4436)

* Generated from b772c09b4e8132be83594f0a834cf7b363445a3c

Address PR description feedback

* Generated from 61d39f048374e3c8dd07112e7d9e8554e8664ea5

Fix casing

* Packaging update of azure-mgmt-web

* Generated from 66114e58530dd7027b63182defcf1c8f73d1d502

Remove incorrect pagination from examples.

* Generated from 13b235cccbe934e60dba491a2a49edcae9c7f275 (#4481)

Fix Hosting Environment Network Dependencies pagination

* [AutoPR web/resource-manager] Update managedserviceidentity type enum (#4761)

* Generated from d605882bdcb7e402badbf4aeca8d66f20a9d197e

Update managedserviceidentity type enum

Enum is currently missing the ua + sa combination + "none" type. We do support those values in our API and as such need the swagger to reflect that.

* Packaging update of azure-mgmt-web

* Generated from 215b006997fc053d43337cd0455d8bdfdbe18898 (#4768)

Add Managed Identity envelope to SitePatchResource

Add Managed Identity envelope to SitePatchResource object to allow PATCH identity operations to a site through Swagger

* [AutoPR web/resource-manager] VnetInfo CertBlob format changed to string (#4860)

* Generated from d0b3b0dc2238ba14b6a41ced8e7ce66e3755f279

VnetInfo CertBlob format changed to string

* Packaging update of azure-mgmt-web

* Generated from 310b5ada2616fb0b8f5808d6d1422df350d459e6 (#5169)

Add examples

* Generated from ca964030410907fee5bc6c2e08d6e5dd934e49a3 (#5190)

Add Source Web App Location

* Generated from 96295fc95567dcd52215bafad85d53dc931adc32 (#5212)

Add Api-version 2018-11-01 for WebApps Collection

Add package Tag

Fix path to common definitions

* Web in new folder

* Generated from ac4cdaf9da165cd1951ce8e10cdd63c78ff04612 (#5472)

Web new path

* ChangeLog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants