address clippy warnings for azure_core (#1398)

sdk/core/src/date/rfc1123.rs

@@ -1,9 +1,7 @@
-use serde::{self, Deserialize, Deserializer, Serializer};
+use crate::date::{parse_rfc1123, to_rfc1123};
+use serde::{self, de, Deserialize, Deserializer, Serializer};
 use time::OffsetDateTime;
 
-use crate::date::*;
-use serde::de;
-
 pub fn deserialize<'de, D>(deserializer: D) -> Result<OffsetDateTime, D::Error>
 where
     D: Deserializer<'de>,
@@ -20,7 +18,7 @@ where
 }
 
 pub mod option {
-    use crate::date::*;
+    use crate::date::{parse_rfc1123, to_rfc1123};
     use serde::{Deserialize, Deserializer, Serializer};
     use time::OffsetDateTime;
 

sdk/core/src/error/http_error.rs

@@ -111,7 +111,7 @@ pub(crate) fn get_error_code_from_body(body: &[u8]) -> Option<String> {
     let nested = || json.get("error")?.get("code")?.as_str();
     let top_level = || json.get("code")?.as_str();
     let code = nested().or_else(top_level);
-    code.map(|c| c.to_owned())
+    code.map(ToOwned::to_owned)
 }
 
 /// Gets the error message if it's present in the body
@@ -122,5 +122,5 @@ pub(crate) fn get_error_message_from_body(body: &[u8]) -> Option<String> {
     let nested = || json.get("error")?.get("message")?.as_str();
     let top_level = || json.get("message")?.as_str();
     let code = nested().or_else(top_level);
-    code.map(|c| c.to_owned())
+    code.map(ToOwned::to_owned)
 }

sdk/core/src/headers/mod.rs

@@ -200,9 +200,10 @@ const fn ensure_no_uppercase(s: &str) {
     let mut i = 0;
     while i < bytes.len() {
         let byte = bytes[i];
-        if byte >= 65u8 && byte <= 90u8 {
-            panic!("header names must not contain any uppercase letters");
-        }
+        assert!(
+            !(byte >= 65u8 && byte <= 90u8),
+            "header names must not contain uppercase letters"
+        );
         i += 1;
     }
 }

sdk/core/src/http_client/mod.rs

@@ -6,7 +6,7 @@ mod reqwest;
 #[cfg(not(any(feature = "enable_reqwest", feature = "enable_reqwest_rustls")))]
 use self::noop::NoopClient;
 #[cfg(any(feature = "enable_reqwest", feature = "enable_reqwest_rustls"))]
-use self::reqwest::*;
+use self::reqwest::new_reqwest_client;
 use crate::error::ErrorKind;
 use async_trait::async_trait;
 use bytes::Bytes;

sdk/core/src/http_client/reqwest.rs

@@ -17,7 +17,7 @@ impl HttpClient for ::reqwest::Client {
     async fn execute_request(&self, request: &crate::Request) -> crate::Result<crate::Response> {
         let url = request.url().clone();
         let method = request.method();
-        let mut req = self.request(try_from_method(method)?, url.clone());
+        let mut req = self.request(try_from_method(*method)?, url.clone());
         for (name, value) in request.headers().iter() {
             req = req.header(name.as_str(), value.as_str());
         }
@@ -65,22 +65,21 @@ fn to_headers(map: &::reqwest::header::HeaderMap) -> crate::headers::Headers {
         .iter()
         .filter_map(|(k, v)| {
             let key = k.as_str();
-            match std::str::from_utf8(v.as_bytes()) {
-                Ok(value) => Some((
+            if let Ok(value) = v.to_str() {
+                Some((
                     crate::headers::HeaderName::from(key.to_owned()),
                     crate::headers::HeaderValue::from(value.to_owned()),
-                )),
-                Err(_) => {
-                    log::warn!("header value for `{key}` is not utf8");
-                    None
-                }
+                ))
+            } else {
+                log::warn!("header value for `{key}` is not utf8");
+                None
             }
         })
         .collect::<HashMap<_, _>>();
     crate::headers::Headers::from(map)
 }
 
-fn try_from_method(method: &crate::Method) -> crate::Result<::reqwest::Method> {
+fn try_from_method(method: crate::Method) -> crate::Result<::reqwest::Method> {
     match method {
         crate::Method::Connect => Ok(::reqwest::Method::CONNECT),
         crate::Method::Delete => Ok(::reqwest::Method::DELETE),

sdk/core/src/lro.rs

@@ -64,7 +64,7 @@ pub mod location {
         Url,
     };
 
-    #[derive(Debug)]
+    #[derive(Debug, Clone, Copy)]
     pub enum FinalState {
         AzureAsyncOperation,
         Location,