Fix the URI param for next token in azure_storage_blobs find_blobs_by_tags
#1253
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
next
(continuation) token forfind_blobs_by_tags
is currently set to thenext
URI param when pagination happens. However, according to Azure documentation https://learn.microsoft.com/en-us/rest/api/storageservices/find-blobs-by-tags?tabs=azure-ad the continuation token should be set on themarker
URI param. Other part of the library is also usingmarker
URI param, except for this particular operation.Because of this incorrect URI param name, when this function is called with more than 5000 results (the upper cap on the result of a single call), the Pageable logic will kick in, and fetch the next page using this token. However, since the API server doesn't see a
marker
value, it will still return that first 5000 results. Which means a user looping through the call would get into an infinite loop.This PR fixes this issue by switching to use the existing
append_to_url_query
function onNextMarker
to do the job.