remove rust-toolchain.toml #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of specifying the toolchain via `rust-toolchain.toml`, our CI pipelines specify the intended toolchain. For contributor's purposes, this is out of sync with what we verify against for PRs and has contributed to confusion over time. For users of the SDK, this isn't applied. For those, we specify the toolchain needed via setting MSRV in the `Cargo.toml` for the specific crate.
|
Rather than keeping various sources up to date, wouldn't it make more sense just to standardize the entire e2e flow on rust-toolchain (or rust-toolchain.toml - I just know a popular GH Actions task, which we don't use, still hasn't added support for the .toml file)? A single source of truth? |
cataggar
approved these changes
Jul 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of specifying the toolchain via
rust-toolchain.toml, our CI pipelines specify the intended toolchain. For contributor's purposes, this is out of sync with what we verify against for PRs and has contributed to confusion over time.For users of the SDK, this isn't applied. For those, we specify the toolchain needed via setting MSRV in the
Cargo.tomlfor the specific crate.