at the time of Pipeline::send, context doesn't need to be mutable #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up until we get to `Pipeline::send`, Context can (and likely will) be mutable. However, once we start processing the pipeline, it doesn't need to be mutable anymore. This is due to `Policy::send` not requiring mutable context. The changes to `azure_iot_hub` and `azure_security_keyvault` are related to longer requiring mutable contexts once we get to `Policy::send`. Ref: https://github.com/Azure/azure-sdk-for-rust/blob/43d4e9974060e78bbd8912ddcc183567781997fc/sdk/core/src/policies/mod.rs#L30-L33
heaths
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until we get to
Pipeline::send, Context can (and likely will) be mutable. However, once we start processing the pipeline, it doesn't need to be mutable anymore. This is due toPolicy::sendnot requiring mutable context.The changes to
azure_iot_hubandazure_security_keyvaultare related to longer requiring mutable contexts once we get toPolicy::send.Ref:
azure-sdk-for-rust/sdk/core/src/policies/mod.rs
Lines 30 to 33 in 43d4e99