Add Snippet Generator as a tool to be published, update dotnet.yml to… #1834
Conversation
chidozieononiwu
commented
Jul 22, 2021
chidozieononiwu
commented
- Add Snippet Generator as a tool to be published, update dotnet.yml to be published to the azure-sdk-tools devOps feed
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: |
|
No CI pipelines seem to be running, is that expected? |
|
@christothes FYI |
… publish to azure-sdk-tools devOps feed
chidozieononiwu
force-pushed
the
AddSnippetGenerator
branch
from
3867c21
to
09f8821
Compare
|
/azp run azure-sdk-tools - dotnet |
|
Azure Pipelines successfully started running 2 pipeline(s). |
chidozieononiwu
force-pushed
the
AddSnippetGenerator
branch
from
24f83bb
to
0c2d1a5
Compare
|
/azp run azure-sdk-tools - dotnet |
|
Azure Pipelines failed to run 2 pipeline(s). |
|
/azp run azure-sdk-tools - dotnet |
|
Azure Pipelines failed to run 2 pipeline(s). |
|
/azp run azure-sdk-tools - dotnet |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run azure-sdk-tools - dotnet |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run azure-sdk-tools - dotnet |
|
Azure Pipelines successfully started running 2 pipeline(s). |
chidozieononiwu
force-pushed
the
AddSnippetGenerator
branch
from
018aa55
to
f5e20a4
Compare
It shows up now. |
|
Doesn't look like generator tests are running. |
chidozieononiwu
force-pushed
the
AddSnippetGenerator
branch
from
3731b4b
to
9b4a060
Compare
chidozieononiwu
force-pushed
the
AddSnippetGenerator
branch
5 times, most recently
from
8dd1412
to
14d5ced
Compare
chidozieononiwu
force-pushed
the
AddSnippetGenerator
branch
from
14d5ced
to
90987e5
Compare
|
Did you manage to get the tests running? |
| @@ -11,7 +11,8 @@ trigger: | |||
| - hotfix/* | |||
| paths: | |||
| include: | |||
| - src/dotnet/Azure.ClientSdk.Analyzers | |||
| - dotnet.proj | |||
| - src/dotnet/* | |||
There was a problem hiding this comment.
I don't think /* is doing what you expect as devops doesn't support wildcards in the paths.
There was a problem hiding this comment.
Oh I see. Will src/dotnet work?
There was a problem hiding this comment.
Yes I believe it should work without the *
| @@ -1,7 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFramework>netstandard2.0</TargetFramework> | |||
| <TargetFramework>net5.0</TargetFramework> | |||
There was a problem hiding this comment.
Did we intend to change this to net5?
There was a problem hiding this comment.
Praveen is fixing this up with another PR.
|
@chidozieononiwu where you able to get the tests working? |
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <Description>Generates code snippets for readmes in the azure-sdk-for-net repo.</Description> | ||
| <TargetFramework>net5.0</TargetFramework> |
There was a problem hiding this comment.
| @@ -0,0 +1,23 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
There was a problem hiding this comment.
For new things comming into the tools repo it would be good if you put them under the "tools/" folder as we want to clean-up the "src/" folder overtime
