Use stress test environment defaults for group and subscription #2363

benbp · 2021-12-01T22:28:28Z

There's no need to have to specify the cluster resource group and subscription when we already know these values ahead of time. We still need to keep them as parameters to enable people to deploy to dev environments they've provisioned themselves.
Fix secret logging in CI mode from New-TestResources
Fix the stress deployment script overwriting pre-existing env variables
Simplify stress chart image handling
Bump addons chart to 0.1.13

azure-sdk · 2021-12-01T22:33:44Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk · 2021-12-02T00:37:30Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

benbp · 2021-12-02T22:15:10Z

@heaths @weshaggard I'd appreciate your review on the New-TestResources.ps1 changes.

azure-sdk · 2021-12-02T22:36:07Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

…I environments

azure-sdk · 2021-12-02T23:00:06Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

eng/common/TestResources/New-TestResources.ps1

eng/common/scripts/stress-testing/deploy-stress-tests.ps1

eng/common/TestResources/New-TestResources.ps1

eng/common/scripts/stress-testing/stress-test-deployment-lib.ps1

azure-sdk · 2021-12-02T23:27:10Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

heaths

After going through the replies and discussing a few things offline, this LGTM but I really dislike the $DevopsLogging name. It's misleading given the intent. Perhaps the original $RedactLogs or something like $SuppressSecretsLogging would be more obvious to future maintainers. The name as it is now is already logging-specific, so I see no harm in hitching a new name to logging. The original $CI was meant to be obvious that it's set only when in a CI, and several behaviors are keyed off that. In this case, it all seems to come down to logging.

eng/common/scripts/stress-testing/stress-test-deployment-lib.ps1

azure-sdk · 2021-12-02T23:46:41Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk · 2021-12-02T23:53:15Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

…om environments

azure-sdk · 2021-12-03T00:37:49Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

weshaggard

Look reasonable but I would use the new DevOpsLogging to condition all vso specific logging not just the secret parts.

azure-sdk · 2021-12-06T18:53:34Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk · 2021-12-06T19:34:51Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

...kubernetes/stress-test-addons/images/test-resource-deployer/deploy-stress-test-resources.ps1

eng/common/TestResources/New-TestResources.ps1.md

azure-sdk · 2021-12-06T21:15:38Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

ghost · 2021-12-07T21:46:07Z

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

benbp · 2021-12-07T22:06:05Z

/check-enforcer override

benbp requested a review from a team as a code owner December 1, 2021 22:28

benbp added the Central-EngSys This issue is owned by the Engineering System team. label Dec 1, 2021

benbp self-assigned this Dec 1, 2021

benbp requested review from ckairen and weshaggard December 1, 2021 22:29

benbp added the Stress This issue is related to stress testing, part of our reliability pillar. label Dec 1, 2021

benbp requested a review from heaths as a code owner December 2, 2021 22:13

benbp force-pushed the benbp/stress-release-env branch from 4cd203e to 0b8e225 Compare December 2, 2021 22:30

benbp added 2 commits December 2, 2021 17:30

Use stress test environment defaults for group and subscription

4ea4e5f

Fix parameter passing from deploy-stress-tests.ps1 script

936b58c

benbp force-pushed the benbp/stress-release-env branch from d9966b9 to 9c56886 Compare December 2, 2021 22:55

benbp added 2 commits December 2, 2021 17:55

Redact stress deployment logs and simplify image handling

c6834be

Use DevopsLogging parameter to prevent secret logging in non-devops C…

9c56886

…I environments

heaths requested changes Dec 2, 2021

View reviewed changes

Use switch type for DevopsLogging parameter

aa54fb8

ckairen reviewed Dec 2, 2021

View reviewed changes

eng/common/scripts/stress-testing/stress-test-deployment-lib.ps1 Show resolved Hide resolved

ckairen reviewed Dec 2, 2021

View reviewed changes

eng/common/scripts/stress-testing/stress-test-deployment-lib.ps1 Outdated Show resolved Hide resolved

heaths approved these changes Dec 2, 2021

View reviewed changes

heaths reviewed Dec 2, 2021

View reviewed changes

eng/common/scripts/stress-testing/stress-test-deployment-lib.ps1 Outdated Show resolved Hide resolved

benbp force-pushed the benbp/stress-release-env branch from 291d4a6 to 96bec15 Compare December 2, 2021 23:49

benbp added 2 commits December 2, 2021 18:49

Remove boolean parameter usage in favor of [switch]

876962c

Add default parameter set usage comment

96bec15

Throw when clusterGroup and/or subscription is not specified for cust…

e437433

…om environments

weshaggard approved these changes Dec 3, 2021

View reviewed changes

benbp force-pushed the benbp/stress-release-env branch from c65252f to b3afd25 Compare December 6, 2021 18:47

Add helper function for logging azure pipelines vso commands

6c1b6b2

benbp force-pushed the benbp/stress-release-env branch from b3afd25 to 6c1b6b2 Compare December 6, 2021 19:29

Invert SuppressVsoCommands binary default value

092c016

weshaggard reviewed Dec 6, 2021

View reviewed changes

...kubernetes/stress-test-addons/images/test-resource-deployer/deploy-stress-test-resources.ps1 Outdated Show resolved Hide resolved

weshaggard reviewed Dec 6, 2021

View reviewed changes

eng/common/TestResources/New-TestResources.ps1.md Outdated Show resolved Hide resolved

Vso command fixes

f52bb16

weshaggard approved these changes Dec 6, 2021

View reviewed changes

azure-sdk added the auto-merge label Dec 7, 2021

ghost merged commit 5d02fb9 into Azure:main Dec 7, 2021

benbp deleted the benbp/stress-release-env branch December 7, 2021 22:06

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use stress test environment defaults for group and subscription #2363

Use stress test environment defaults for group and subscription #2363

benbp commented Dec 1, 2021 •

edited

Loading

azure-sdk commented Dec 1, 2021

azure-sdk commented Dec 2, 2021

benbp commented Dec 2, 2021

azure-sdk commented Dec 2, 2021

azure-sdk commented Dec 2, 2021

azure-sdk commented Dec 2, 2021

heaths left a comment

azure-sdk commented Dec 2, 2021

azure-sdk commented Dec 2, 2021

azure-sdk commented Dec 3, 2021

weshaggard left a comment

azure-sdk commented Dec 6, 2021

azure-sdk commented Dec 6, 2021

azure-sdk commented Dec 6, 2021

ghost commented Dec 7, 2021

benbp commented Dec 7, 2021

Use stress test environment defaults for group and subscription #2363

Use stress test environment defaults for group and subscription #2363

Conversation

benbp commented Dec 1, 2021 • edited Loading

azure-sdk commented Dec 1, 2021

azure-sdk commented Dec 2, 2021

benbp commented Dec 2, 2021

azure-sdk commented Dec 2, 2021

azure-sdk commented Dec 2, 2021

azure-sdk commented Dec 2, 2021

heaths left a comment

Choose a reason for hiding this comment

azure-sdk commented Dec 2, 2021

azure-sdk commented Dec 2, 2021

azure-sdk commented Dec 3, 2021

weshaggard left a comment

Choose a reason for hiding this comment

azure-sdk commented Dec 6, 2021

azure-sdk commented Dec 6, 2021

azure-sdk commented Dec 6, 2021

ghost commented Dec 7, 2021

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

benbp commented Dec 7, 2021

benbp commented Dec 1, 2021 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.