Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch the ms.service from some source of truth #2890

Closed
sima-zhu opened this issue Mar 8, 2022 · 5 comments
Closed

Fetch the ms.service from some source of truth #2890

sima-zhu opened this issue Mar 8, 2022 · 5 comments
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team.

Comments

@sima-zhu
Copy link
Contributor

sima-zhu commented Mar 8, 2022

The docs ms.service is currently set to service directory and not able to override if it is wrong value.

Needs to fetch the value from other source of truth.

Proposal:

  1. Add 'ms.service' to csv data, so team can update value there, if no value, then defaults to service directory.

Long-term goal:

  1. Align and sync the value with Taxonomies service: https://review.docs.microsoft.com/en-us/help/contribute/metadata-taxonomies?branch=main#msservice
@ghost ghost added the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Mar 8, 2022
@sima-zhu sima-zhu self-assigned this Mar 8, 2022
@sima-zhu sima-zhu added Central-EngSys This issue is owned by the Engineering System team. and removed needs-triage This is a new issue that needs to be triaged to the appropriate team. labels Mar 8, 2022
@sima-zhu
Copy link
Contributor Author

@weshaggard
Copy link
Member

When you add this column to the csv script please name it as MSDocService and add it readme file https://github.com/Azure/azure-sdk/blob/main/eng/README.md and also initialize it in https://github.com/Azure/azure-sdk/blob/main/eng/scripts/PackageList-Helpers.ps1#L43.

@sima-zhu
Copy link
Contributor Author

#2910

@sima-zhu
Copy link
Contributor Author

#1442

@sima-zhu
Copy link
Contributor Author

The issue has been fixed which we have a way to override the value in csv file. Closed the issue and open a new one for future use case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

No branches or pull requests

2 participants