Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use underscore-prefixed variable name when setting sub config values as secrets #1563

Merged
1 commit merged into from
Apr 19, 2021
Merged

Use underscore-prefixed variable name when setting sub config values as secrets #1563

1 commit merged into from
Apr 19, 2021

Conversation

benbp
Copy link
Member

@benbp benbp commented Apr 19, 2021

The way we are setting subscription configuration values as secrets causes Azure Pipelines to exclude them from the environment variables available to tasks when they are set by the deployment script. Prefix any subscription configuration keys with an underscore to avoid this problem.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@ghost
Copy link

ghost commented Apr 19, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit b9ed8bc into Azure:master Apr 19, 2021
@benbp benbp deleted the benbp/testing-multiple-sub-config-secret branch April 19, 2021 21:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants