Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: Storing .env file for bicep file at service dir #1943

Merged
2 commits merged into from Aug 27, 2021
Merged

Bug fix: Storing .env file for bicep file at service dir #1943

2 commits merged into from Aug 27, 2021

Conversation

ckairen
Copy link
Member

@ckairen ckairen commented Aug 26, 2021

New-TestResources.ps1 was storing the .env file at the temp folder if the service uses bicep files. This bug fix stores the .env file at the correct service directory.

(also pushed in logging request in #1876)

@ckairen ckairen requested a review from benbp August 26, 2021 22:25
@ckairen ckairen linked an issue Aug 26, 2021 that may be closed by this pull request
New-TestResources stores environment settings into the wrong file when using bicep #1824
Closed
@ckairen ckairen marked this pull request as ready for review August 26, 2021 22:26
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

heaths
heaths approved these changes Aug 27, 2021
View reviewed changes
eng/common/TestResources/New-TestResources.ps1 Outdated Show resolved Hide resolved
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp
Copy link
Member

benbp commented Aug 27, 2021

CC @pakrym

pakrym
pakrym approved these changes Aug 27, 2021
View reviewed changes
Copy link
Contributor

@pakrym pakrym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAY!

This was referenced Aug 27, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ghost
Copy link

ghost commented Aug 27, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit edc75f5 into Azure:main Aug 27, 2021
@ckairen ckairen deleted the albertcheng/store-env branch November 22, 2021 21:33
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbp benbp benbp approved these changes

@heaths heaths heaths approved these changes

@pakrym pakrym pakrym approved these changes

@danieljurek danieljurek Awaiting requested review from danieljurek

@weshaggard weshaggard Awaiting requested review from weshaggard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New-TestResources stores environment settings into the wrong file when using bicep
5 participants
@ckairen @azure-sdk @benbp @heaths @pakrym