Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc-warden] sdk/*/<directory> is matching too generically #2020

Closed
scbedd opened this issue Sep 16, 2021 · 4 comments
Closed

[doc-warden] sdk/*/<directory> is matching too generically #2020

scbedd opened this issue Sep 16, 2021 · 4 comments
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team.

Comments

@scbedd
Copy link
Member

scbedd commented Sep 16, 2021

sdk/*/READMe.md is matching readmes like sdk/schemaregistry/azure-schemaregistry/README.md.

This should require the ** glob pattern. Need to dig in an understand why.

This bug is the cause of confusion over in Azure/azure-sdk-for-js#16869

@scbedd scbedd added the Central-EngSys This issue is owned by the Engineering System team. label Sep 16, 2021
@scbedd scbedd self-assigned this Sep 16, 2021
@weshaggard weshaggard assigned chidozieononiwu and unassigned scbedd Sep 16, 2021
@weshaggard
Copy link
Member

Unless it is critical and you are already investigating @scbedd lets let @chidozieononiwu look at this as pat of some similar issues he has.

@scbedd
Copy link
Member Author

scbedd commented Sep 21, 2021

It's not critical (as they are running day to day with this bug), but we probably should fix sooner rather than later.

@chidozieononiwu , this is the problem.

I've been waffling back and forth thinking about how to resolve this. I think the solution may be to convert the simple globbing patterns to regex, then do a re.match() on the path. Let's chat offline when you have a few moments?

@ramya-rao-a
Copy link

Hello!
Any updates here?

@kurtzeborn
Copy link
Member

At this point we're not going to fix this. More likely, we're going to transition away from DocWarden entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Archived in project
Development

No branches or pull requests

5 participants