[Swift APIView] Create intermediate models and SwiftAPIViewTests package #3069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjprescott
force-pushed
the
swift/ModelOverhaul
branch
3 times, most recently
from
568e0c5
to
f4ef41f
Compare
tjprescott
force-pushed
the
swift/ModelOverhaul
branch
from
f4ef41f
to
db35168
Compare
mpodwysocki
reviewed
Apr 21, 2022
| checkIndent() | ||
| let item = Token(definitionId: definitionId, navigateToId: nil, value: text, kind: .text) | ||
| // TODO: Add cross-language definition ID | ||
| // if add_cross_language_id: |
There was a problem hiding this comment.
Is this just for Swift or across languages?
There was a problem hiding this comment.
I just left comment here so I know where to add it. Right now only Python has this implemented.
mpodwysocki
reviewed
Apr 21, 2022
| } | ||
|
|
||
| // TODO: Add support for diagnostics | ||
| // func diagnostic(self, text, line_id): |
There was a problem hiding this comment.
Are diagnostics disabled across the board?
There was a problem hiding this comment.
They've never been implemented in Swift APIView, so I added this to come to later.
mpodwysocki
reviewed
Apr 21, 2022
| decl.members.forEach { member in | ||
| switch member { | ||
| case let .declaration(decl): | ||
| // TODO: We need to push these into the relevant object definitions. |
There was a problem hiding this comment.
What does this mean? Push the extension declaration into the proper Extended class?
There was a problem hiding this comment.
It was more me thinking out loud. Part of: #2536
I'm not yet sure what the best way would be.
benbp
pushed a commit
to benbp/azure-sdk-tools
that referenced
this pull request
May 6, 2022
…age (Azure#3069) * Initial work. * Refactoring progress. * Refactoring progress. * More refactoring. * Fixes and extract tests to new test project. * Address fixes. * More updates. Add operator and precedence group tests. * Fix navigation. Add attribute tests. * Fix issues with enums. Add enum test file. * TypeModel improvements. * Add FunctionsTestFile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor extracts tests out to a
SwiftAPIViewTestspackage a la Python, adds a number of new tests from Apple's own documentation, and adds an internal intermediate model that will allow us to manipulate objects in support of fixing the issues we see with extensions. Fixes #3091.This PR does not attempt to fix the issue with extensions. It just lays that groundwork.
APIView: https://apiviewstaging.azurewebsites.net/Assemblies/Review/a0490ca69cf740cea3ce6fabad9c3c67/2b0384fd32894ecfa24edfcd73a11cff