Add methods to skip lint check and fix typehint regex #585
Conversation
| # load all modules and parse them recursively | ||
| for m in modules: | ||
| if not m.startswith(root_module): |
There was a problem hiding this comment.
Can you give me an example of this running for something we DONT own? Just for my own reference.
There was a problem hiding this comment.
Good question - I'm also curious :)
There was a problem hiding this comment.
It's not fully generalized. I have tried for few external packages and it didn't work. This fix is to mainly avoid other folders in package root other than "Azure". I will debug what's wrong in generating stub for external package.
| TYPEHINT_NOT_REQUIRED_METHODS = ["close",] | ||
| REGEX_ITEM_PAGED = "~[\w.]*\.([\w]*)\s?[\[\(][\w]*[\]\)]" | ||
| TYPEHINT_NOT_REQUIRED_METHODS = ["close", "__init__"] | ||
| REGEX_ITEM_PAGED = "~[\w.]*\.([\w]*)\s?[\[\(][^\n]*[\]\)]" |
There was a problem hiding this comment.
Making certain I grok this, you're moving to explicitly include everything up to the newline because otherwise you were just eating comments right?
There was a problem hiding this comment.
REGEX for item paged was finding only part of return type if type is like ~azure..ItemPaged[someType[SomeSubType]]. Previous REGEX stops scan as soon as it find closing bracket.
|
@praveenkuttappan, @scbedd is correct - tools/sdks/etc shouldn't set the log level. Only add messages at an appropriate level. It would be up to the consumer of said tool to configure the log level. You could look at moving this to the console entry point (i.e. within the actual function so as to isolate it from the lib proper) and have it configurable by one of the cmd args. Though given that it was already there I'm happy for that to be addressed in a subsequent PR |
Changes: