Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare-Release.ps1: Make dateTime.ToString("MM/dd/yyyy") to work on exotic setups #7615

Merged
merged 4 commits into from
Feb 2, 2024

Conversation

antkmsft
Copy link
Member

@antkmsft antkmsft commented Feb 1, 2024

On my machine, I experimented with the registry, and the worst part is that I don't remember/know how to reset it back.

The work items that script produces, do have datetimes for the upcoming releases in the MM-dd-yyyy format, and then I have to correct them by hand.

dateTime.ToString("MM/dd/yyyy") does produce the date in the format of MM-dd-yyyy on my machine. This also happens if I write a corresponding .NET app.

The fix that I am proposing makes it work on my specific setup and hopefully breaks no one else. I understand if you are hesitant to take it. Let me know, I'll see how I can restore my setting.

But on the other hand, I don't think it makes anything worse, it only makes things more robust, so maybe take it?

…exotic set-ups

On my machine, I experimented with the registry, and the worst part is that I don't remember/know how to reset it back.

The work items that script produces, do have datetimes for the upcoming releases in the `MM-dd-yyyy` format, and then I have to correct them by hand.

`dateTime.ToString("MM/dd/yyyy")` does produce the date in the format of `MM-dd-yyyy` on my machine. This also happens if I write a corresponding .NET app.

The fix that I am proposing makes it work on my specific setup and hopefully breaks no one else. I understand if you are hesitant to take it. Let me know, I'll see how I can restore my setting.

But on the other hand, I don't think it makes anything worse, it only makes things more robust, so maybe take it?
@antkmsft antkmsft changed the title Prepare-Release.ps1: Make dateTime.ToString("MM/dd/yyyy") to work on exotic set-ups Prepare-Release.ps1: Make dateTime.ToString("MM/dd/yyyy") to work on exotic setups Feb 1, 2024
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@antkmsft antkmsft enabled auto-merge (squash) February 2, 2024 18:02
azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Feb 2, 2024
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#7615 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
@weshaggard weshaggard enabled auto-merge (squash) February 2, 2024 18:43
@weshaggard weshaggard merged commit 996d965 into main Feb 2, 2024
11 checks passed
@weshaggard weshaggard deleted the antkmsft-patch-1 branch February 2, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants