Skip to content

Commit

Permalink
Webhook removal - WIP (#205)
Browse files Browse the repository at this point in the history
* partial webhook removal

* remove generated files from source control

* removed gitignore

* fixed keyvault controller logging

* reverted generated code removal
  • Loading branch information
szoio authored and WilliamMortlMicrosoft committed Sep 12, 2019
1 parent 27a1bae commit a5d91b3
Show file tree
Hide file tree
Showing 11 changed files with 45 additions and 321 deletions.
1 change: 0 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -201,5 +201,4 @@ install-test-dependency:
&& go get github.com/axw/gocov/gocov \
&& go get github.com/AlekSi/gocov-xml \
&& go get github.com/onsi/ginkgo/ginkgo \
&& go get github.com/onsi/gomega/... \
&& go get golang.org/x/tools/cmd/cover
82 changes: 0 additions & 82 deletions api/v1/eventhub_webhook.go

This file was deleted.

86 changes: 0 additions & 86 deletions api/v1/eventhubnamespace_webhook.go

This file was deleted.

2 changes: 1 addition & 1 deletion api/v1/zz_generated.deepcopy.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ limitations under the License.
package v1

import (
"k8s.io/apimachinery/pkg/runtime"
runtime "k8s.io/apimachinery/pkg/runtime"
)

// DeepCopyInto is an autogenerated deepcopy function, copying the receiver, writing into out. in must be non-nil.
Expand Down
4 changes: 2 additions & 2 deletions config/default/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,12 @@ patchesStrategicMerge:
#- manager_prometheus_metrics_patch.yaml

# [WEBHOOK] To enable webhook, uncomment all the sections with [WEBHOOK] prefix including the one in crd/kustomization.yaml
- manager_webhook_patch.yaml
# - manager_webhook_patch.yaml

# [CAINJECTION] Uncomment next line to enable the CA injection in the admission webhooks.
# Uncomment 'CAINJECTION' in crd/kustomization.yaml to enable the CA injection in the admission webhooks.
# 'CERTMANAGER' needs to be enabled to use ca injection
- webhookcainjection_patch.yaml
# - webhookcainjection_patch.yaml
# the following config is for teaching kustomize how to do var substitution
# the following config is for teaching kustomize how to do var substitution
vars:
Expand Down
Loading

0 comments on commit a5d91b3

Please sign in to comment.