Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding VNetRule additional types fields (Postgresql and MySql) #1009

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Adding VNetRule additional types fields (Postgresql and MySql) #1009

merged 2 commits into from
Apr 29, 2020

Conversation

melonrush13
Copy link
Contributor

Closes #1007

What this PR does / why we need it:
Adding provisioned and message fields to Postgresqlvnetrule and MySqlvnetrule

Special notes for your reviewer:

  • Create a PostgreSqlVNetRule
  • Create a MySqlVNetRule
  • Verify with a k get to see fields "Message" and "Provisioned" instead of "Age".

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

Copy link
Contributor

@WilliamMortlMicrosoft WilliamMortlMicrosoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@melonrush13 melonrush13 merged commit 47a949a into Azure:master Apr 29, 2020
@melonrush13 melonrush13 deleted the morefields branch April 29, 2020 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Add fields to K Get for MySqlVNetRule and PostgreSqlVNetRule
2 participants