Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in the cosmosdb yaml file #1031

Merged
merged 5 commits into from
May 12, 2020
Merged

Conversation

buhongw7583c
Copy link
Contributor

@buhongw7583c buhongw7583c commented May 7, 2020

Closes #1030
Correct the sample cosmosDB yaml file.

What this PR does / why we need it:
To correct the typos and format issues of the sample cosmosDB yaml file.

Special notes for your reviewer:
--Use the current cosmosDB sample yaml file to enable virtual network and iprules (firewall). The cosmosDB would be created with no vnet/firewall settings.
-- Apply the modified yaml file and the vnet/firewall shall be configured.
image

To quickly check the yaml file settings have been submitted from kubectl. Be able to see the ip rules, virtual network rules have all been set with the correct values.

 kubectl describe cosmosdb                   
Name:         cosmosdb-sample-1
Namespace:    default
Labels:       <none>
Annotations:  kubectl.kubernetes.io/last-applied-configuration:
                {"apiVersion":"azure.microsoft.com/v1alpha1","kind":"CosmosDB","metadata":{"annotations":{},"name":"cosmosdb-sample-1","namespace":"defaul...
API Version:  azure.microsoft.com/v1alpha1
Kind:         CosmosDB
Metadata:
  Creation Timestamp:  2020-05-06T10:58:52Z
  Finalizers:
    azure.microsoft.com/finalizer
  Generation:  2
  Owner References:
    API Version:           azure.microsoft.com/v1alpha1
    Block Owner Deletion:  true
    Controller:            true
    Kind:                  ResourceGroup
    Name:                  resourcegroup-azure-operators
    UID:                   79217d7a-7f0b-4ce4-8e3f-d423e7fb1f68
  Resource Version:        57355
  Self Link:               /apis/azure.microsoft.com/v1alpha1/namespaces/default/cosmosdbs/cosmosdb-sample-1
  UID:                     33ccd8cc-256f-4077-ba16-289a4b295c86
Spec:
  Ip Rules:
    104.42.195.92
    1.2.3.4
  Kind:      GlobalDocumentDB
  Location:  westus
  Properties:
    Database Account Offer Type:        Standard
    Is Virtual Network Filter Enabled:  true
  Resource Group:                       resourcegroup-azure-operators
  Virtual Network Rules:
    Ignore Missing V Net Service Endpoint:  true
    Subnet ID:                              /subscriptions/***/resourceGroups/resourcegroup-azure-operators/providers/Microsoft.Network/virtualNetworks/vnet-sample-01/subnets/test1

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

@jananivMS jananivMS changed the title Issue1030 Fix typos in the cosmosdb yaml file May 7, 2020
@frodopwns frodopwns requested a review from jpflueger May 7, 2020 19:45
@buhongw7583c buhongw7583c merged commit dbecdd7 into Azure:master May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: typos of the sample yaml of cosmosDB results to vnet creation failure
3 participants