Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add backup retention and geo redundant backup configurability #1051

Merged
merged 17 commits into from
May 15, 2020
Merged

add backup retention and geo redundant backup configurability #1051

merged 17 commits into from
May 15, 2020

Conversation

frodopwns
Copy link
Contributor

@frodopwns frodopwns commented May 14, 2020 •
edited
Loading

Closes #1042

What this PR does / why we need it:
adds the ability to configure storage options for MySQL and PSQL Servers

Special notes for your reviewer:

  • new functionality is in v1alpha2
  • to see the storage options in the portal go to Pricing Tier
  1. Deploy a v1alpha1 MySQL and PSQL Server
  2. Then deploy v1alpha2 versions after uncommenting the storage profile options in the manifest.
  3. Ensure all deploy correctly
  4. Test whatever edge cases come to mind

How does this PR make you feel:
gif

@frodopwns frodopwns changed the title WIP - add backup retention and geo redundant backup configurability add backup retention and geo redundant backup configurability May 14, 2020
@frodopwns frodopwns requested a review from jananivMS May 14, 2020 22:23
jananivMS
jananivMS previously approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@jananivMS jananivMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Postgresqlserver works fine. Mysqlserver works for v1alpha2 but v1alpha1 gives a wierd webhook cert error. But we could address this later to unblock customer if needed.

jananivMS
jananivMS previously approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@jananivMS jananivMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

jananivMS
jananivMS approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@jananivMS jananivMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good now

@frodopwns frodopwns merged commit e18cbc7 into Azure:master May 15, 2020
@buhongw7583c
Copy link
Contributor

I used v2 to verify mysql and pgresql and all went well.

cnadolny pushed a commit to cnadolny/azure-service-operator that referenced this pull request May 26, 2020
@frodopwns @cnadolny
add backup retention and geo redundant backup configurability (Azure#…
8c85576 
…1051)

add backup retention and georedundancy for psql and mysql
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jananivMS jananivMS jananivMS approved these changes

@buhongw7583c buhongw7583c Awaiting requested review from buhongw7583c

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task: Add Backup Retention and Backup Redundancy to PSQL/MySQL
3 participants
@frodopwns @buhongw7583c @jananivMS