Wimortl/sql #116
Wimortl/sql #116
Conversation
* improve tests with parallel execution and rm sleep * fix the tests to run on kindcluster
* feat: implement keyvault controller * Ace's KV changes with updates * Added an event for the final successful provisioning * Updated changes based on the PR comments * removing unwanted file * making resource group name the one in the keyvault yaml Co-authored-by: Ace Eldeib <alexeldeib@gmail.com>
|
New test output: Williams-MBP:sqlclient wmortl$ go test |
…service-operator into wimortl/sql
|
@frodopwns I fixed the small stuff @jananivMS all async changes are in |
| return false, fmt.Errorf("cannot create sql server: %v", err) | ||
| } | ||
|
|
||
| return true, nil |
There was a problem hiding this comment.
Will, I am going to approve this for now, but we should discuss about if we should change this to return the result (gotten from future.Result) which would confirm that the async operation is in progress.
The support for signal handling was already hooked up but we didn’t check for cancellation anywhere. With this change we check for cancellation: * During JSON Schema loading: for each HTTP request or file open. * While cleaning the output directory: once per file or directory to be cleaned, also while walking the tree. * While converting the JSON AST: once per handler. * While emitting the output files: once per package. The JSON Schema library doesn’t support cancellation so this is implemented there by supplying a filesystem implementation that supports cancellation; there is no way to supply an implementation for the HTTP requests so instead we add cancellation to the global HTTP transport (in `gen.go`). We should try and push a change upstream to either add cancellation overall or allow overriding the HTTP client/transport. Fixes #116.
What this PR does / why we need it:
sql server client
Special notes for your reviewer:
If applicable: