-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create/update/delete firewall rules for SQL servers #148
create/update/delete firewall rules for SQL servers #148
Conversation
* improve tests with parallel execution and rm sleep * fix the tests to run on kindcluster
* feat: implement keyvault controller * Ace's KV changes with updates * Added an event for the final successful provisioning * Updated changes based on the PR comments * removing unwanted file * making resource group name the one in the keyvault yaml Co-authored-by: Ace Eldeib <alexeldeib@gmail.com>
* this needs to exist in the reconciler in order to use controllerutil createorupdate
* add consumer group kind * update tests for consumer group * fix isbeingdeleted
* cluster additions * updated docs
* Update azure-pipelines.yaml
* revert back // +kubebuilder:subresource:status changes - fix broken tests
* add dev conatiner - wip * DevContainer up and running. * Removed `sleep 80` and replaced with `kubectl wait`. * Run `make set-kindcluster` from docker-compose. * Set timeout on wait. * Added `install-test-dependency` to makefile and dockerfile. * Update README - Create SP with contribution rights. * Updated README with details on using devcontainer. * Stuff that wanted me to commit. * Reverted changes made to `docker-build` in Makefile.
* first commit on Amanda's branch * first * before properties * test not tested * test works * unit tests work, needs firewall rules * addresses feedback * erin's feedback * janani's change, pass future * async works much better now * janani feedback * screwed up interface prototype
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests passed for me
+1. Tests also passed.
|
Don’t override global HTTP handler 😉
What this PR does / why we need it:
This PR allows for the creation / updating / deletion of firewall rules for SQL servers. The end to end unit test has been updated with additional tests for firewall rules.
Special notes for your reviewer:
If applicable: