initial pr template draft #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frodopwns please rebase the commits. |
bingosummer
approved these changes
Jul 20, 2019
zhongyi-zhang
pushed a commit
that referenced
this pull request
Jul 24, 2019
frodopwns
pushed a commit
that referenced
this pull request
Sep 10, 2019
Merge pull request #1 from Azure/master
jananivMS
added a commit
that referenced
this pull request
Dec 13, 2019
PR comments and updates - blob container operator and underlying storage account operator
jskulavik
added a commit
that referenced
this pull request
Dec 19, 2019
* Basic integration test harness for azuresqluser_controller * Integration test compiling and working, just not passing yet due to SQL issues * initial sql action controller test * initial sql action controller test * WIP sql action controller tests * resolve merge conflict * get tests to pass for PR * some cleanup * Full stub for SQL User INT test * AzureSQLUser integration tests passing * Invoke controller-gen in Docker container * Go install controller-gen explicitly * Copy hack and api dirs to container * ADD hack dir to container * Properly ADD hack dir to container * Dockerfile and dockerignore fixes to enable CI container deployment to AKS * Add comment clarity in Dockerfile * Fix merge conflict and use proper struct for suite_test * Basic integration test harness for azuresqluser_controller * Integration test compiling and working, just not passing yet due to SQL issues * Full stub for SQL User INT test * AzureSQLUser integration tests passing * Fix merge conflict and use proper struct for suite_test * Refactor based on PR feedback and addition of status change checking. * Refactor sqlUser integration test and suite references * WIP: SQLUser integration tests debugging * SecretClient nil pointer debugging * Add SecretClient to AzureSQLUserReconciler instantiation in suite_test * AzureSQLUser test cleanup * Fix NamespacedName parameter for SQLUser * test-existing logs indicate success; removal of action test from this branch to reduce noise * Fixing sql user controller tests * missed couple files (#2) * Remove commented-out code; delete firewall rule post-test * Consolidate deletions of resources post-test runs
jananivMS
pushed a commit
to jananivMS/azure-service-operator
that referenced
this pull request
Jun 5, 2020
changes to make mysqluser rbac work & updated helm chart
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This template will show up in the editing textbox when new PRs are opened.
I find it useful to help clean up issues when PRs finish the work from the issue. It can also be helpful to remind users about testing and describing the necessary steps to test.