Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing AdminUser from SqlServer #220

Merged
merged 1 commit into from
Sep 13, 2019
Merged

Removing AdminUser from SqlServer #220

merged 1 commit into from
Sep 13, 2019

Conversation

melonrush13
Copy link
Contributor

@melonrush13 melonrush13 commented Sep 12, 2019 •
edited

Solves #219

What this PR does / why we need it:

  • Removes AdminUser from spec (sqlserver_types.go)
  • Removes AdminUser name from sample yaml (azure.microsoft.com_sqlservers.yaml)

To Test:
Test to see if SQL Server correctly provisions in Azure by running:

Terminal 1
make install
make run

Terminal 2
kubectl create -f config/samples/azure_v1_resourcegroup.yaml
kubectl create -f config/samples/azure_v1_sqlserver.yaml

Returns sqlserver.azure.microsoft.com/sqlserver-sample-rush created
and resources exist in Azure -> code works!

If applicable:

  • this PR contains documentation
  • this PR contains tests

@melonrush13 melonrush13 mentioned this pull request Sep 12, 2019
Closed
aka-msft
aka-msft approved these changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@aka-msft aka-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me

@melonrush13 melonrush13 merged commit d832dfa into Azure:azure-sql Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aka-msft aka-msft aka-msft approved these changes

@jananivMS jananivMS Awaiting requested review from jananivMS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@melonrush13 @aka-msft