Adding Message field to SqlServerStatus and messages to sqlserver controller

[melonrush13]

#246

What this PR does / why we need it:

• Adding message field to SqlServerStatus
• Adding messages throughout the sqlserver controller using instance.Status.Message
• Fixing spelling errors in sqlserver controller logs

Special notes for your reviewer:
To Test:

• In terminal window 1: Run make run
• In terminal window 2: Create a new sqlserver instance using kubectl create -f config/samples/azure_v1_sqlserver.yaml
• Run k get sqlserver $sqlservernamel -o yaml

Should see the following output, with a new message field in the bottom under status:

➜azure-service-operator git:(msgstatus) ✗ k get sqlserver bearsawesomesql -o yaml
apiVersion: azure.microsoft.com/v1
kind: SqlServer
metadata:
  creationTimestamp: "2019-10-01T19:58:31Z"
  finalizers:
  - sqlserver.finalizers.azure.com
  generation: 1
  name: bearsawesomesql
  namespace: default
  resourceVersion: "601382"
  selfLink: /apis/azure.microsoft.com/v1/namespaces/default/sqlservers/bearsawesomesql
  uid: d8104caf-e485-11e9-b1dc-5a2bc381628e
spec:
  allowazureserviceaccess: true
  location: westus
  resourcegroup: bearrg
status:
  message: Successfully Submitted to Azure
  provisioned: true
  state: Ready➜  azure-service-operator git:(msgstatus) ✗ k get sqlserver bearsawesomesql -o yaml
apiVersion: azure.microsoft.com/v1
kind: SqlServer
metadata:
  creationTimestamp: "2019-10-01T19:58:31Z"
  finalizers:
  - sqlserver.finalizers.azure.com
  generation: 1
  name: bearsawesomesql
  namespace: default
  resourceVersion: "601382"
  selfLink: /apis/azure.microsoft.com/v1/namespaces/default/sqlservers/bearsawesomesql
  uid: d8104caf-e485-11e9-b1dc-5a2bc381628e
spec:
  allowazureserviceaccess: true
  location: westus
  resourcegroup: bearrg
status:
  message: Successfully Submitted to Azure
  provisioned: true
  state: Ready

If applicable:

• this PR contains documentation
• this PR contains tests

[jananivMS]

Looks good. Some changes requested.

[melonrush13]

Fixes:

• Added messages to the sqlserver_controller_finalizer
• Fixed some message sentences (CreateOrUpdateSQLServer, Firewall)

Q's:

• Should I continue to follow the if updaterr across the code, or switch all the if's to err?
• Make manifest generated the same file as my manual edit. Planning to keep my manual edits unless someone suggests otherwise

Would love a re-review when you get a minute :) @jananivMS @WilliamMortlMicrosoft

[melonrush13]

Added! @frodopwns

[frodopwns]

LGTM

[frodopwns]

@melonrush13 the test output says this:

pkg/resourcemanager/sqlclient/sqlclient_godsk.go:257:24: GoSDKClient.GetServer redeclared in this block
	previous declaration at pkg/resourcemanager/sqlclient/sqlclient_godsk.go:126:6
Makefile:97: recipe for target 'vet' failed
make: *** [vet] Error 2

but I don't see that error when I check out your branch

[melonrush13]

@melonrush13 the test output says this:

pkg/resourcemanager/sqlclient/sqlclient_godsk.go:257:24: GoSDKClient.GetServer redeclared in this block
	previous declaration at pkg/resourcemanager/sqlclient/sqlclient_godsk.go:126:6
Makefile:97: recipe for target 'vet' failed
make: *** [vet] Error 2

but I don't see that error when I check out your branch

just ran this morning, @frodopwns, and also didn't get that error the tests spit out. Still able to get messages on a k get sqlserver x without problems.

[jananivMS]

lg except for the comments

[jananivMS]

This one is hanglng without a Update. I would suggest just removing this. Rest looks good

[jananivMS]

Everything else looks good.

[jananivMS]

Looks good!

got approval