-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Message field to SqlServerStatus and messages to sqlserver controller #258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Some changes requested.
Fixes:
Q's:
Would love a re-review when you get a minute :) @jananivMS @WilliamMortlMicrosoft |
Co-Authored-By: Erin Corson <frodopwns@gmail.com>
Added! @frodopwns |
Co-Authored-By: Erin Corson <frodopwns@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@melonrush13 the test output says this:
but I don't see that error when I check out your branch |
just ran this morning, @frodopwns, and also didn't get that error the tests spit out. Still able to get messages on a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg except for the comments
added unneeded file change
controllers/sqlserver_controller.go
Outdated
@@ -355,6 +373,7 @@ func (r *SqlServerReconciler) GetOrPrepareSecret(instance *azurev1.SqlServer) (* | |||
|
|||
if err := r.Get(context.Background(), types.NamespacedName{Name: name, Namespace: instance.Namespace}, secret); err == nil { | |||
r.Log.Info("secret already exists, pulling creds now") | |||
instance.Status.Message = "Secret exists on instance" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is hanglng without a Update. I would suggest just removing this. Rest looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
* Rename comment helper methods for clarity * Use renamed comment helpers
#246
What this PR does / why we need it:
message
field to SqlServerStatusSpecial notes for your reviewer:
To Test:
make run
kubectl create -f config/samples/azure_v1_sqlserver.yaml
k get sqlserver $sqlservernamel -o yaml
Should see the following output, with a new message field in the bottom under status:
If applicable: