-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch quickstart workflow for devcontainer #259
Conversation
add watch for parent eventhub when secret changes (#235)
…erator into patch/devcont_quickstart
@Azadehkhojandi could you have someone on your side who is familiar with the devcontainer workflow take a look at this PR? |
replace hard coded http status code (#255)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and I've tested it and it works too. But will wait for Stephen, Az, Priya to also take a look before approving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a potential issue if new users try to build the Dockerfile if zz_generated.deepcopy.go
isn't generated prior. You've added RUN make generate
to the Dockerfile but because hack
has been added to .dockerignore
, zz_generated.deepcopy.go
isn't generated inside the container and if make generate
isn't executed prior to building the image, zz_generated.deepcopy.go
wont be copied into the image, and as a result the image will fail to build.
I would suggest running make generate
when running make set-kindcluster
and removing RUN make generate
from the Dockerfile, or remove hack
from .dockerignore
to allow boilerplate.go.txt
to be copied into the image.
…t/azure-service-operator into patch/devcont_quickstart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
…t/azure-service-operator into patch/devcont_quickstart
…erator into patch/devcont_quickstart
What this PR does / why we need it:
This PR patches a few small issues with the devcontainer quickstart workflow.
Special notes for your reviewer:
To Test:
If applicable:
this PR contains documentation
this PR contains tests