fixed YAML, removed check name functionality #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamMortlMicrosoft
requested review from
frodopwns,
melonrush13 and
jananivMS
WilliamMortlMicrosoft
changed the title
jananivMS
suggested changes
Oct 2, 2019
There was a problem hiding this comment.
I would revert the removal of resourcegroup from the Sqldatabase scheme as one of the scenarios that used to work isnt. And we may nmeed that for a customer. I would recommend pushing the other changes without it as they are important to unblock folks on azure-sql
WilliamMortlMicrosoft
changed the title
jananivMS
approved these changes
Oct 3, 2019
Porges
added a commit
that referenced
this pull request
May 11, 2021
When producing an object for a `OneOf` type, naming information is lost when collapsing types like `AllOf` into objects. To fix this we will produce names before collapsing types in order to preserve the original names. If there are multiple names produced for an `AllOf` we prefer the one that is derived from a `TypeName` or is at a lower “inheritance” depth.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.) added back the YAML samples
2.) backed out Mel's code for checking names