-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed YAML, removed check name functionality #276
fixed YAML, removed check name functionality #276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would revert the removal of resourcegroup from the Sqldatabase scheme as one of the scenarios that used to work isnt. And we may nmeed that for a customer. I would recommend pushing the other changes without it as they are important to unblock folks on azure-sql
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it looks good.
When producing an object for a `OneOf` type, naming information is lost when collapsing types like `AllOf` into objects. To fix this we will produce names before collapsing types in order to preserve the original names. If there are multiple names produced for an `AllOf` we prefer the one that is derived from a `TypeName` or is at a lower “inheritance” depth.
1.) added back the YAML samples
2.) backed out Mel's code for checking names