Add tests to ResourceGroup_Controller #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szoio
reviewed
Oct 8, 2019
frodopwns
approved these changes
Oct 10, 2019
szoio
approved these changes
Oct 10, 2019
|
@clmccart looks like the most recent failure is complaining about https://github.com/clmccart/azure-service-operator/blob/patch/rg_controller_tests/controllers/resourcegroup_controller_test.go#L40 which referts to azurev1 instead of azurev1alpha1 |
|
Looks good, thanks @clmccart ! |
Porges
pushed a commit
that referenced
this pull request
May 11, 2021
… types (#287) * Foo.name -> Foo.fooName to avoid confusion with FakeResource.name I was getting very confused by what I thought was FakeResource.name being optional, when I hadn't clicked that both FakeResource and Foo have .name and Foo.name is optional. * Deepcopy maps, arrays and optional types This required some special handling in the case of enums. These are handled by adding a flag to the params that suppresses conversion for TypeNames when the type names are the same, since the only thing that will be true for is enums - every other type will have an arm variant generated.. * Removed unnecessary if statement from map copying in ConvertToArm Since we create the target map before the check and iterating over a nil map does the right thing, the `if sourceMap != nil` check isn't needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds additional tests to the resourcegroup_controller_test.go file.
This is necessary because, while using TDD to recreate the resourcegroup operator as an upskilling exercise, I discovered that you could get all of the current resource group controller tests to pass without ever creating or deleting anything in kubernetes or azure.
This PR adds in tests that prove that the resource group controller actually creates and deletes resource group instances.
Special notes for your reviewer:
To test this:
If applicable: