Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySQL AAD Admin #2954

Merged
merged 1 commit into from
May 11, 2023
Merged

MySQL AAD Admin #2954

merged 1 commit into from
May 11, 2023

Conversation

matthchr
Copy link
Member

@matthchr matthchr commented May 8, 2023

Add support for MySQL AAD Administrator

If applicable:

  • this PR contains documentation
  • this PR contains tests

│ │ └── PropertyBag: genruntime.PropertyBag
│ ├── TenantId: *string
│ └── Type: *string
└── augmentConversionForSystemData_STATUS: Interface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have an augmentConversion interface for only STATUS?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SystemData property only exists on the Status type. All of the other properties on the Spec are primitives or genruntime types.

So I think this is correct, the only complex child type is SystemData and it only exists on status, so that's the only complex child we have augmentConversionFor interfaces for?

docs/hugo/content/reference/_index.md Show resolved Hide resolved
@matthchr
Copy link
Member Author

/ok-to-test sha=a07bfcb

@matthchr
Copy link
Member Author

Should swap to use the 2022-01-01 GA API of this

@matthchr
Copy link
Member Author

Can't swap to GA API because it doesn't actually work:

PUT https://management.azure.com/subscriptions/4ef44fef-c51d-4d7c-a6ff-8635c02848b1/resourceGroups/asotest-rg-mvhpcy/providers/Microsoft.DBforMySQL/flexibleServers/asotest-mysql-xiucnj/administrators/ActiveDirectory

        --------------------------------------------------------------------------------

        RESPONSE 400: 400 Bad Request

        ERROR CODE: NoRegisteredProviderFound

        --------------------------------------------------------------------------------

        {

          "error": {

            "code": "NoRegisteredProviderFound",

            "message": "No registered resource provider found for location 'eastus' and API version '2022-01-01' for type 'flexibleServers'. The supported api-versions are '2020-07-01-privatepreview, 2020-07-01-preview, 2021-05-01-preview, 2021-05-01, 2021-12-01-preview, 2022-06-01-privatepreview, 2022-06-01-preview, 2022-09-30-privatepreview, 2022-09-30-preview'. The supported locations are 'australiacentral, australiasoutheast, canadaeast, eastasia, eastus2, germanynorth, germanywestcentral, centralindia, southindia, japanwest, koreasouth, northcentralus, norwayeast, norwaywest, swedencentral, uaenorth, ukwest, westcentralus, westus, westus2, westus3, brazilsouth, brazilsoutheast, francecentral, francesouth, southafricanorth, southafricawest, southeastasia, northeurope, australiaeast, japaneast, koreacentral, uksouth, westeurope, canadacentral, centralus, eastus, switzerlandnorth, switzerlandwest, southcentralus, qatarcentral'."

          }

        }

@matthchr
Copy link
Member Author

/ok-to-test sha=c6441f5

@matthchr matthchr merged commit 74003ad into Azure:main May 11, 2023
9 checks passed
@matthchr matthchr deleted the feature/mysql-admin branch May 11, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants