-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opt-in to sending explicit payloads to ARM #3060
Conversation
Let's see if CoPilot works ... copilot:summary copilot:walkthrough |
/prbot review |
b1d505c
to
2cb356b
Compare
v2/azure-arm.yaml
Outdated
# | ||
# Valid values are: | ||
# omitempty - only non-empty properties are included (default) | ||
# collection - always include collections, even if empty; other properties only if specified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
payloadType: collection
doesn't read super descriptively to me. Wondering if there's a better name? Maybe payloadType: explicitCollection
(to match the explicit
phrasing below?)
Or payloadType: alwaysEmitCollections
v2/tools/generator/internal/codegen/pipeline/create_arm_types.go
Outdated
Show resolved
Hide resolved
v2/tools/generator/internal/codegen/pipeline/create_arm_types.go
Outdated
Show resolved
Hide resolved
v2/tools/generator/internal/codegen/pipeline/create_arm_types.go
Outdated
Show resolved
Hide resolved
66aae38
to
751f8fd
Compare
751f8fd
to
c3483c4
Compare
Codecov Report
@@ Coverage Diff @@
## main #3060 +/- ##
==========================================
+ Coverage 54.21% 54.25% +0.04%
==========================================
Files 1400 1400
Lines 601177 601252 +75
==========================================
+ Hits 325920 326231 +311
+ Misses 221858 221628 -230
+ Partials 53399 53393 -6
|
What this PR does / why we need it:
As identified in #2914, some Azure Resource Providers work more as a PATCH than a PUT, allowing unwarrented drift to occur without correction by ASO.
This PR adds the option
$payloadType
so we can opt-in certain groups for being more explicit with the payloads they send to ARM.Closes #2914
Special notes for your reviewer:
I've left the door open for configuration of this at the object and property level, but given the behaviour we've seen so far, configuration at the group level seemed appropriate.
How does this PR make you feel:
Copilot Summary
copilot:summary
Copilot Walkthrough
copilot:walkthrough