Fix: sqlserver name validation error handling #315
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #277
What this PR does / why we need it:
Checks for invalid server name, and handles error.
Special notes for your reviewer:
Create an invalid server name (Ex: sqlserver1.2) and run
k create -f config/samples/azure_v1_sqlserver.yaml
In a separate terminal, run
make run
Should see the following output based on your server name:
2019-10-09T11:56:25.647-0600 DEBUG controller-runtime.manager.events Warning {"object": {"kind":"SqlServer","namespace":"default","name":"sqlserver-sample-testerooni1.1","uid":"1bb940fb-eabe-11e9-b1dc-5a2bc381628e","apiVersion":"azure.microsoft.com/v1","resourceVersion":"1480525"}, "reason": "Failed", "message": "Unable to provision or update instance"} 2019-10-09T11:56:25.647-0600 DEBUG controller-runtime.manager.events Warning {"object": {"kind":"SqlServer","namespace":"default","name":"sqlserver-sample-testerooni1.1","uid":"1bb940fb-eabe-11e9-b1dc-5a2bc381628e","apiVersion":"azure.microsoft.com/v1","resourceVersion":"1480525"}, "reason": "Failed", "message": "Invalid Server Name"}
If applicable: