Use createOrRecover for sample keyvaults #3370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
davefellows,
matthchr,
babbageclunk and
super-harsh
as code owners
theunrepentantgeek
force-pushed
the
feature/goal-seeking-keyvaults
branch
from
b27efb2
to
2b5a5da
Compare
Merged
3 tasks
theunrepentantgeek
force-pushed
the
feature/goal-seeking-keyvault-samples
branch
from
0d90c2d
to
c473562
Compare
theunrepentantgeek
force-pushed
the
feature/goal-seeking-keyvault-samples
branch
from
c473562
to
d62f0df
Compare
super-harsh
reviewed
Oct 19, 2023
| @@ -43,4 +44,3 @@ spec: | |||
| - "get" | |||
| storage: | |||
| - "get" | |||
|
|
|||
There was a problem hiding this comment.
The diff is interesting. I've removed a missing EOLN by adding one. 😉
super-harsh
approved these changes
Oct 19, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Updates our samples with KeyVaults to use
createModeset tocreateOrRecoverso they are somewhat more resilient.Prerequisites
Special notes for your reviewer:
Recovering a KeyVault only works if the soft-deleted KeyVault is in the same subscription as where you're trying to create a new one, so this isn't a universal fix.
How does this PR make you feel:
If applicable: