-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use createOrRecover for sample keyvaults #3370
Merged
theunrepentantgeek
merged 7 commits into
main
from
feature/goal-seeking-keyvault-samples
Oct 20, 2023
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1829c8b
Use createOrRecover for sample keyvaults
theunrepentantgeek 7b3f61d
Update samples
theunrepentantgeek d62f0df
Update recordings
theunrepentantgeek 793d35a
Update recordings
theunrepentantgeek 2b07ac1
Update recording
theunrepentantgeek 084320d
Merge branch 'main' into feature/goal-seeking-keyvault-samples
theunrepentantgeek a1dd4f2
Merge branch 'main' into feature/goal-seeking-keyvault-samples
theunrepentantgeek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
1,610 changes: 1,141 additions & 469 deletions
1,610
...s_CreationAndDeletion/Test_Containerservice_v1api20230202preview_CreationAndDeletion.yaml
Large diffs are not rendered by default.
Oops, something went wrong.
178 changes: 102 additions & 76 deletions
178
.../recordings/Test_Samples_CreationAndDeletion/Test_Keyvault_v1api_CreationAndDeletion.yaml
Large diffs are not rendered by default.
Oops, something went wrong.
258 changes: 37 additions & 221 deletions
258
...recordings/Test_Samples_CreationAndDeletion/Test_Keyvault_v1beta_CreationAndDeletion.yaml
Large diffs are not rendered by default.
Oops, something went wrong.
2,038 changes: 812 additions & 1,226 deletions
2,038
...t_Samples_CreationAndDeletion/Test_Machinelearningservices_v1api_CreationAndDeletion.yaml
Large diffs are not rendered by default.
Oops, something went wrong.
1,577 changes: 796 additions & 781 deletions
1,577
..._Samples_CreationAndDeletion/Test_Machinelearningservices_v1beta_CreationAndDeletion.yaml
Large diffs are not rendered by default.
Oops, something went wrong.
3 changes: 2 additions & 1 deletion
3
v2/samples/containerservice/v1api20230202preview/refs/v1api20210401preview_vault.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,4 +20,4 @@ spec: | |
keyVaultReference: | ||
group: keyvault.azure.com | ||
kind: Vault | ||
name: mlworkspaces-vault | ||
name: aso-cs-vault |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3
v2/samples/machinelearningservices/v1api/refs/v1api20210401preview_vault.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3
v2/samples/machinelearningservices/v1beta/refs/v1beta20210401preview_vault.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: New line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff is interesting. I've removed a missing EOLN by adding one. 😉