Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use createOrRecover for sample keyvaults #3370

Merged
merged 7 commits into from
Oct 20, 2023
Merged

Use createOrRecover for sample keyvaults #3370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1829c8b
Use createOrRecover for sample keyvaults
theunrepentantgeek Oct 3, 2023
7b3f61d
Update samples
theunrepentantgeek Oct 3, 2023
d62f0df
Update recordings
theunrepentantgeek Oct 3, 2023
793d35a
Update recordings
theunrepentantgeek Oct 16, 2023
2b07ac1
Update recording
theunrepentantgeek Oct 18, 2023
084320d
Merge branch 'main' into feature/goal-seeking-keyvault-samples
theunrepentantgeek Oct 19, 2023
a1dd4f2
Merge branch 'main' into feature/goal-seeking-keyvault-samples
theunrepentantgeek Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1,610 changes: 1,141 additions & 469 deletions ...s_CreationAndDeletion/Test_Containerservice_v1api20230202preview_CreationAndDeletion.yaml
View file
Open in desktop

Large diffs are not rendered by default.

178 changes: 102 additions & 76 deletions .../recordings/Test_Samples_CreationAndDeletion/Test_Keyvault_v1api_CreationAndDeletion.yaml
View file
Open in desktop

Large diffs are not rendered by default.

258 changes: 37 additions & 221 deletions ...recordings/Test_Samples_CreationAndDeletion/Test_Keyvault_v1beta_CreationAndDeletion.yaml
View file
Open in desktop

Large diffs are not rendered by default.

2,038 changes: 812 additions & 1,226 deletions ...t_Samples_CreationAndDeletion/Test_Machinelearningservices_v1api_CreationAndDeletion.yaml
View file
Open in desktop

Large diffs are not rendered by default.

1,577 changes: 796 additions & 781 deletions ..._Samples_CreationAndDeletion/Test_Machinelearningservices_v1beta_CreationAndDeletion.yaml
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion v2/samples/containerservice/v1api20230202preview/refs/v1api20210401preview_vault.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
apiVersion: keyvault.azure.com/v1api20210401preview
kind: Vault
metadata:
name: mlworkspaces-vault
name: aso-cs-vault
namespace: default
spec:
location: westus3
owner:
name: aso-sample-rg
properties:
createMode: createOrRecover
tenantId: 00000000-0000-0000-0000-000000000000
sku:
family: A
Expand Down
2 changes: 1 addition & 1 deletion v2/samples/containerservice/v1api20230202preview/refs/v1api20210701_workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ spec:
keyVaultReference:
group: keyvault.azure.com
kind: Vault
name: mlworkspaces-vault
name: aso-cs-vault
2 changes: 1 addition & 1 deletion v2/samples/keyvault/v1api/v1api20210401preview_vault.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ spec:
owner:
name: aso-sample-rg
properties:
createMode: createOrRecover
tenantId: "00000000-0000-0000-0000-000000000000"
sku:
family: A
Expand Down Expand Up @@ -43,4 +44,3 @@ spec:
- "get"
storage:
- "get"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: New line

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff is interesting. I've removed a missing EOLN by adding one. 😉

1 change: 1 addition & 0 deletions v2/samples/keyvault/v1beta/v1beta20210401preview_vault.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ spec:
owner:
name: aso-sample-rg
properties:
createMode: createOrRecover
tenantId: "00000000-0000-0000-0000-000000000000"
sku:
family: A
Expand Down
3 changes: 2 additions & 1 deletion v2/samples/machinelearningservices/v1api/refs/v1api20210401preview_vault.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
apiVersion: keyvault.azure.com/v1api20210401preview
kind: Vault
metadata:
name: mlworkspaces-vault
name: ms-ws-vault
namespace: default
spec:
location: westus3
owner:
name: aso-sample-rg
properties:
createMode: createOrRecover
tenantId: "00000000-0000-0000-0000-000000000000"
sku:
family: A
Expand Down
2 changes: 1 addition & 1 deletion v2/samples/machinelearningservices/v1api/v1api20210701_workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ spec:
keyVaultReference:
group: "keyvault.azure.com"
kind: "Vault"
name: "mlworkspaces-vault"
name: "ms-ws-vault"
# Optional: Save the keys for the storage account into a Kubernetes secret
operatorSpec:
secrets:
Expand Down
3 changes: 2 additions & 1 deletion v2/samples/machinelearningservices/v1beta/refs/v1beta20210401preview_vault.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
apiVersion: keyvault.azure.com/v1beta20210401preview
kind: Vault
metadata:
name: aso-ml-vault
name: aso-v-mls
namespace: default
spec:
location: westus3
owner:
name: aso-sample-rg
properties:
tenantId: "00000000-0000-0000-0000-000000000000"
createMode: createOrRecover
sku:
family: A
name: standard
Expand Down
2 changes: 1 addition & 1 deletion v2/samples/machinelearningservices/v1beta/v1beta20210701_workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ spec:
keyVaultReference:
group: "keyvault.azure.com"
kind: "Vault"
name: "aso-ml-vault"
name: "aso-v-mls"
# Optional: Save the keys for the storage account into a Kubernetes secret
operatorSpec:
secrets:
Expand Down