Rename SQL resources to AzureSQL #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aka-msft
requested review from
frodopwns,
melonrush13,
WilliamMortlMicrosoft and
jananivMS
aka-msft
changed the title
|
@frodopwns @jananivMS Update: No longer a WIP, ready for review. Tagging you in case you have free time and want to take a look at this - Will and I chatted and he is already tracking on it. |
|
needs to fix sql action meta data issue where it points to the sql server as its parent... take a look at sql firewall rule for the code to do this |
|
tested by creating and deleting (including cascading delete of sql server) sql servers, databases, and firewall rules |
WilliamMortlMicrosoft
approved these changes
Oct 14, 2019
Porges
pushed a commit
that referenced
this pull request
May 11, 2021
* Track used imports when generating * Emit only used imports * Add MustGetImportedPackageName() and use to simplify code * Pass package name into FormatError() * Pass package name into NewTestFuncDetails() * Use MustGetImportedPackageName() and simplify code * Use CodeGenerationContext to find package name for 'encoding/json'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #231
What this PR does / why we need it:
Note: Initially a WIP - Waiting for some firewall rule code to get merged before doing a rename on those files.
Renames SqlServer, SqlDatabase, SqlFirewallRule, and SqlAction (rolling credentials) to AzureSqlServer, AzureSqlDatabase, AzureSqlFirewallRule, and AzureSqlAction, respectively. Resolves ambiguity in the type of SQL services being implemented, and makes room for other future database implementations such as PostgresSQL or MySQL, etc.
Special notes for your reviewer:
Run operator and check to make sure that an AzureSQL server, database, and firewall rule can still be created successfully and show up in the portal. Get the DB password from the k8s secret, base64 decode, then use it to log into the database to test. Run the AzureSqlAction to roll credentials using the operator. Get the new password from the k8s secret, base64 decode, then test to make sure the new password can be used to log into the database.
If applicable: