Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag support for Redis Cache #787

Merged
merged 4 commits into from
Mar 19, 2020
Merged

Tag support for Redis Cache #787

merged 4 commits into from
Mar 19, 2020

Conversation

melonrush13
Copy link
Contributor

@melonrush13 melonrush13 commented Mar 18, 2020

Closes #720

What this PR does / why we need it:

  • Adds tag support for Redis Cache
  • Renaming RC name in yaml to nicer-string :)

Special notes for your reviewer:
Expected behavior after creating a redis cache:
Screen Shot 2020-03-18 at 12 39 41 PM

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

@melonrush13
Copy link
Contributor Author

Did not get any errors like the ones from PR #775 - hopefully it works for whoever is testing, too :)

@WilliamMortlMicrosoft
Copy link
Contributor

testing now

@melonrush13 melonrush13 merged commit 9c2ace8 into Azure:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Add ability to add tags to rediscache during provisioning
2 participants