updating provisioning flags #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frodopwns
reviewed
Mar 26, 2020
pkg/resourcemanager/azuresql/azuresqldb/azuresqldb_reconcile.go
Outdated
Show resolved
Hide resolved
WilliamMortlMicrosoft
suggested changes
Mar 27, 2020
WilliamMortlMicrosoft
suggested changes
Mar 27, 2020
WilliamMortlMicrosoft
approved these changes
Mar 27, 2020
WilliamMortlMicrosoft
approved these changes
Mar 27, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #704
What this PR does / why we need it:
This sets the provisioning flag to false when Azure SQL resources haven't started provisioning yet due to other errors. We need this so the provisioning metric is more accurate.
Special notes for your reviewer:
Test Cases:
How does this PR make you feel:
If applicable: