Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task#574 #940

Merged
merged 3 commits into from
Apr 15, 2020
Merged

Task#574 #940

merged 3 commits into from
Apr 15, 2020

Conversation

buhongw7583c
Copy link
Contributor

Closes #475

What this PR does / why we need it:
The PR is to add unhappy controller test cases for postgresql server, database and firewall rules.
Special notes for your reviewer:

The controller test should all passed.

make BUILD_TAGS=psqlserver test-existing-controllers

2020/04/14 13:05:22 finished common controller test setup
=== RUN   TestPSQLServerControllerNoResourceGroup
=== PAUSE TestPSQLServerControllerNoResourceGroup
=== CONT  TestPSQLServerControllerNoResourceGroup
--- PASS: TestPSQLServerControllerNoResourceGroup (9.07s)
PASS
2020/04/14 13:05:31 Started common controller test teardown
2020/04/14 13:05:37 Finished common controller test teardown
ok      github.com/Azure/azure-service-operator/controllers     134.617s

make BUILD_TAGS=psqldatabase test-existing-controllers

=== RUN   TestPSQLDatabaseControllerNoResourceGroup
=== PAUSE TestPSQLDatabaseControllerNoResourceGroup
=== RUN   TestPSQLDatabaseControllerNoSever
=== PAUSE TestPSQLDatabaseControllerNoSever
=== CONT  TestPSQLDatabaseControllerNoResourceGroup
=== CONT  TestPSQLDatabaseControllerNoSever
--- PASS: TestPSQLDatabaseControllerNoResourceGroup (9.08s)
--- PASS: TestPSQLDatabaseControllerNoSever (15.09s)
PASS
2020/04/14 16:21:50 Started common controller test teardown
2020/04/14 16:21:55 Finished common controller test teardown
ok      github.com/Azure/azure-service-operator/controllers     181.847s

make BUILD_TAGS=psqlfirewallrule test-existing-controllers

=== RUN   TestPSQLFirewallRuleControllerNoResourceGroup
=== PAUSE TestPSQLFirewallRuleControllerNoResourceGroup
=== RUN   TestPSQLFirewallRuleControllerNoServer
=== PAUSE TestPSQLFirewallRuleControllerNoServer
=== CONT  TestPSQLFirewallRuleControllerNoResourceGroup
=== CONT  TestPSQLFirewallRuleControllerNoServer
--- PASS: TestPSQLFirewallRuleControllerNoServer (6.09s)
--- PASS: TestPSQLFirewallRuleControllerNoResourceGroup (6.11s)
PASS
2020/04/14 15:41:32 Started common controller test teardown
2020/04/14 15:41:37 Finished common controller test teardown
ok      github.com/Azure/azure-service-operator/controllers     33.797s

How does this PR make you feel:
gif

If applicable:

  • this PR contains documentation
  • this PR contains tests

@buhongw7583c buhongw7583c linked an issue Apr 14, 2020 that may be closed by this pull request
1 task
Copy link
Contributor

@WilliamMortlMicrosoft WilliamMortlMicrosoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@buhongw7583c buhongw7583c merged commit 4515608 into Azure:master Apr 15, 2020
@buhongw7583c buhongw7583c deleted the task#574 branch April 15, 2020 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants