Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: SQL Action reconciliation doesn't retry on firewall rule error #944

Merged
merged 17 commits into from
Apr 18, 2020
Merged

Bug: SQL Action reconciliation doesn't retry on firewall rule error #944

merged 17 commits into from
Apr 18, 2020

Conversation

WilliamMortlMicrosoft
Copy link
Contributor

closes #891

Describe the bug
When I deploy a SQL Server and Database with a "rollusercreds" action without a firewall rule, the first reconciliation fails and doesn't retry if I re-deploy with a firewall rule.

To Reproduce
Steps to reproduce the behavior:

  • Deploy SQL Server, Database, User and "rollusercreds" action without a firewall rule
  • See that the user and action doesn't provision but the action has FailedProvisioning = true and the user doesn't
  • Redeploy with a firewall rule that fixes the error
  • See that the user re-reconciles and provisions successfully but the action does not re-reconcile

Expected behavior
The SQL Action should re-reconcile on a failed firewall rule in case the user fixes it in the portal or re-deploys with a firewall rule.

@WilliamMortlMicrosoft WilliamMortlMicrosoft added bug 🪲 Something isn't working azure-sql labels Apr 14, 2020
@WilliamMortlMicrosoft WilliamMortlMicrosoft self-assigned this Apr 14, 2020
@frodopwns frodopwns requested a review from cnadolny April 15, 2020 16:25
Copy link
Contributor

@cnadolny cnadolny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works as expected now - both SQL User and SQL Action successfully provision after adding on the Firewall Rule.

@WilliamMortlMicrosoft WilliamMortlMicrosoft merged commit dac4cb2 into Azure:master Apr 18, 2020
@WilliamMortlMicrosoft WilliamMortlMicrosoft deleted the actionFix branch April 18, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: SQL Action reconciliation doesn't retry on firewall rule error
2 participants