-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: SQL Action reconciliation doesn't retry on firewall rule error #944
Merged
WilliamMortlMicrosoft
merged 17 commits into
Azure:master
from
WilliamMortlMicrosoft:actionFix
Apr 18, 2020
Merged
Bug: SQL Action reconciliation doesn't retry on firewall rule error #944
WilliamMortlMicrosoft
merged 17 commits into
Azure:master
from
WilliamMortlMicrosoft:actionFix
Apr 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CosmosDB test region workaround (#896)
reset failed provisioning in case the outcome changes
cnadolny
approved these changes
Apr 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it works as expected now - both SQL User and SQL Action successfully provision after adding on the Firewall Rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #891
Describe the bug
When I deploy a SQL Server and Database with a "rollusercreds" action without a firewall rule, the first reconciliation fails and doesn't retry if I re-deploy with a firewall rule.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The SQL Action should re-reconcile on a failed firewall rule in case the user fixes it in the portal or re-deploys with a firewall rule.