Add include-before parameter for Copy #1205
Conversation
|
Any chance this PR will make it into the mainline any time soon, @amishra-dev? We urgently need this feature, and it would be great to see it merged and released. Any pointers on ETA would be greatly appreciated (would be great if we could avoid having to build this ourselves) |
|
@amishra-dev was interested in doing a review, but seems to be AFK in October based on their public profile. |
zezha-msft
requested review from
adreed-msft,
zezha-msft,
nakulkar-msft and
mohsha-msft
and removed request for
adreed-msft
There was a problem hiding this comment.
Lgtm in general, only one minor point to fix.
Let's get a second pair of eyes on this. @nakulkar-msft @adreed-msft @mohsha-msft
|
Thanks for the quick review @zezha-msft. I've pushed a commit to fix your remarks. |
|
Could you please consider doing a second review @mohsha-msft / @amishra-dev? I would be very grateful if it were possible to include this PR in 10.8.0 🤞🏻. |
On it. Will try to include the changes in v10.8.0 |
There was a problem hiding this comment.
Changes look good to me. Flow is very similar to include-after flag. Let's run CI for regression testing.
https://dev.azure.com/azstorage/AzCopy-NextGen/_build/results?buildId=3395&view=results
|
The failing tests seem unrelated? 🤞🏻 |
|
Rebased and running here: https://dev.azure.com/azstorage/AzCopy-NextGen/_build/results?buildId=3552&view=results |
|
Rebased and merging using this PR instead. |
|
Thanks @evenh for the contribution! |
Fixes #1075.
cc @amishra-dev