Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[AzCopy][Github#1596] InvalidBlobName ._. (AWS S3 bucket -> Azure Blob Storage)" #1644

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Revert "[AzCopy][Github#1596] InvalidBlobName ._. (AWS S3 bucket -> Azure Blob Storage)" #1644

merged 1 commit into from
Jan 5, 2022

Conversation

mohsha-msft
Copy link
Contributor

Reverts #1608

@mohsha-msft mohsha-msft merged commit 475f8e1 into main Jan 5, 2022
@dvalentiate
Copy link

@mohsha-msft

Why was this reverted?

strings.Contains(objectKey, "/.") appears to be a bug that has been reintroduced by this change.

This prevents common files such as app/.gitignore and app/.npmrc and I think app/.github/ from being copied from S3 to the blob storage.

@mohsha-msft
Copy link
Contributor Author

Hey @dvalentiate ,

Thanks for reaching out!

These changes will be included in next release of AzCopy 10.14.0. I've already merged to our dev branch. #1645. The reason I reverted was because I accidentally merged it with main branch.
You can always go ahead and build AzCopy from dev branch if this change is needed by you urgently.

I hope I answered your question.

@mohsha-msft mohsha-msft deleted the revert-1608-mohsha-msft/S3toAzureInvalidBlobName branch February 9, 2022 04:38
mohsha-msft added a commit that referenced this pull request Feb 22, 2022
@tiverma-msft @mohsha-msft
AzCopy throwing "panic error" when using "--include-before" option #1655
a3ba1b8 
 (#1677)

* Fix Invalid Blob Name (#1608)

* Revert "Fix Invalid Blob Name (#1608)" (#1644)

This reverts commit deac65d.

* AzCopy throwing "panic error" when using "--include-before" option #1655

Co-authored-by: Mohit Sharma <65536214+mohsha-msft@users.noreply.github.com>
siminsavani-msft pushed a commit that referenced this pull request Mar 9, 2022
@mohsha-msft @siminsavani-msft
Revert "Fix Invalid Blob Name (#1608)" (#1644)
5358431 
This reverts commit deac65d.
mohsha-msft added a commit that referenced this pull request Mar 15, 2022
@zezha-msft @mohsha-msft @siminsavani-msft
Merge main back to dev after 10.14 (#1691)
f4e5770 
* Fix Invalid Blob Name (#1608)

* Revert "Fix Invalid Blob Name (#1608)" (#1644)

This reverts commit deac65d.

* Fix handling of env variable (#1686)

* Added Component Governance Component Detection (#1690)

Co-authored-by: Mohit Sharma <65536214+mohsha-msft@users.noreply.github.com>
Co-authored-by: siminsavani-msft <77068571+siminsavani-msft@users.noreply.github.com>
mohsha-msft added a commit that referenced this pull request Mar 16, 2022
@zezha-msft @mohsha-msft @siminsavani-msft
Dev <- Main after 10.14.1 (#1712)
e2673aa 
* Fix Invalid Blob Name (#1608)

* Revert "Fix Invalid Blob Name (#1608)" (#1644)

This reverts commit deac65d.

* Fix handling of env variable (#1686)

* Added Component Governance Component Detection (#1690)

Co-authored-by: Mohit Sharma <65536214+mohsha-msft@users.noreply.github.com>
Co-authored-by: siminsavani-msft <77068571+siminsavani-msft@users.noreply.github.com>
nakulkar-msft added a commit that referenced this pull request Mar 30, 2022
@nakulkar-msft
Squashed commit of the following:
d2ab0a7 
(Merge origin/dev)

commit 380f113
Author: Narasimha Kulkarni <nakulkar@microsoft.com>
Date:   Wed Mar 30 08:05:12 2022 +0530

    Fix memleak in chunkedFileWriter (#1695)

    * Fix memleak in chunkedFileWriter

    * Ensure Flush waits for workerRoutine to exit

    * Rename variable to a more meaningful one

commit d76b7bf
Author: Narasimha Kulkarni <nakulkar@microsoft.com>
Date:   Wed Mar 30 08:04:49 2022 +0530

    Refactor STE: Part 3 (#1732)

    * Move global status manager to jobMgr

    * Initialize exculsive string map before first order

    * Add daemon Mode to jobMgr

    * Notify on completion

commit ddec1b9
Author: Narasimha Kulkarni <nakulkar@microsoft.com>
Date:   Tue Mar 29 15:21:56 2022 +0530

    Env var to control downloading to temp path (#1667)

    * Env var to control downloading to temp path

    * Implement TempPath method in mockedLCM

commit 4360757
Author: Narasimha Kulkarni <nakulkar@microsoft.com>
Date:   Mon Mar 28 16:09:29 2022 +0530

    Refactor STE: Separate JobsAdmin out of STE (#1719)

commit 93a3b74
Author: Narasimha Kulkarni <nakulkar@microsoft.com>
Date:   Thu Mar 24 07:48:09 2022 +0530

    Introduce syslogger to be used with STE (#1721)

    * Introduce syslogger to be used with STE

    * Fix windows build

    * Address reviews

commit 832fa4c
Author: Mohit Sharma <65536214+mohsha-msft@users.noreply.github.com>
Date:   Thu Mar 24 07:46:15 2022 +0530

    Changed timeout to 60m (#1718)

commit 1ac90a4
Author: adreed-msft <49764384+adreed-msft@users.noreply.github.com>
Date:   Wed Mar 16 11:07:56 2022 -0700

    Implement OAuth in the modern test framework (#1410)

    * Configure Azure Pipelines for OAuth on E2E

    * Handle separate source/destination request lists

    * Reduce surface area of oauth testing

    * Update function signatures

    * Fix panic

    * Set OAuth info

    * Fix auth for remove

    * Fix resume support

    * Fix objectTarget

    * Fix CopyToWrongBlobType

    * Fix StripTopDir

    * Reduce scale of TestResume_LargeGeneric

    * Add CPK vars

    * Add HNS key

    * Fix test definitions

    * Add E2E classic account key

    * Resolve Mohit's comments

commit 6e2c8e7
Author: Mohit Sharma <65536214+mohsha-msft@users.noreply.github.com>
Date:   Wed Mar 16 21:07:10 2022 +0530

    Fix error message in local traverser (issue #849) (#1713)

    * Log the failure to scan local files to help debugging

    * return error trace as well.

    Co-authored-by: Adele Reed <adreed@microsoft.com>

commit e2673aa
Author: Ze Qian Zhang <zezha@microsoft.com>
Date:   Wed Mar 16 03:39:13 2022 -0700

    Dev <- Main after 10.14.1 (#1712)

    * Fix Invalid Blob Name (#1608)

    * Revert "Fix Invalid Blob Name (#1608)" (#1644)

    This reverts commit deac65d.

    * Fix handling of env variable (#1686)

    * Added Component Governance Component Detection (#1690)

    Co-authored-by: Mohit Sharma <65536214+mohsha-msft@users.noreply.github.com>
    Co-authored-by: siminsavani-msft <77068571+siminsavani-msft@users.noreply.github.com>

commit 84bd216
Author: Mohit Sharma <65536214+mohsha-msft@users.noreply.github.com>
Date:   Wed Mar 16 14:08:31 2022 +0530

    MinIO TraceOn in DEBUG mode (#1678)

    * Added TraceOn in MinIO

    * Minor Edits

    * Redesigned

    * Changes when logger is nil. Passing unit tests.

    * Scrubbing off unnecessary changes

    * Removed extra changes

commit 7ee54bc
Author: Mohit Sharma <65536214+mohsha-msft@users.noreply.github.com>
Date:   Wed Mar 16 13:29:36 2022 +0530

    Updated Dependencies. (#1708)

commit f4e5770
Author: Ze Qian Zhang <zezha@microsoft.com>
Date:   Tue Mar 15 11:01:13 2022 -0700

    Merge main back to dev after 10.14 (#1691)

    * Fix Invalid Blob Name (#1608)

    * Revert "Fix Invalid Blob Name (#1608)" (#1644)

    This reverts commit deac65d.

    * Fix handling of env variable (#1686)

    * Added Component Governance Component Detection (#1690)

    Co-authored-by: Mohit Sharma <65536214+mohsha-msft@users.noreply.github.com>
    Co-authored-by: siminsavani-msft <77068571+siminsavani-msft@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mohsha-msft @dvalentiate