Env var to control downloading to temp path #1667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohsha-msft
reviewed
Feb 7, 2022
mohsha-msft
approved these changes
Feb 22, 2022
zezha-msft
approved these changes
Mar 2, 2022
| @@ -590,6 +591,15 @@ func (lcm *lifecycleMgr) IsForceLoggingDisabled() bool { | |||
| return lcm.disableSyslog | |||
| } | |||
|
|
|||
| func (lcm *lifecycleMgr) DownloadToTempPath() bool { | |||
| ret, err := strconv.ParseBool(lcm.GetEnvironmentVariable(EEnvironmentVariable.DownloadToTempPath())) | |||
There was a problem hiding this comment.
consider doing what SetForceLogging does above, and save the parsed result rather than parsing it every time.
nakulkar-msft
added a commit
that referenced
this pull request
Mar 30, 2022
(Merge origin/dev) commit 380f113 Author: Narasimha Kulkarni <nakulkar@microsoft.com> Date: Wed Mar 30 08:05:12 2022 +0530 Fix memleak in chunkedFileWriter (#1695) * Fix memleak in chunkedFileWriter * Ensure Flush waits for workerRoutine to exit * Rename variable to a more meaningful one commit d76b7bf Author: Narasimha Kulkarni <nakulkar@microsoft.com> Date: Wed Mar 30 08:04:49 2022 +0530 Refactor STE: Part 3 (#1732) * Move global status manager to jobMgr * Initialize exculsive string map before first order * Add daemon Mode to jobMgr * Notify on completion commit ddec1b9 Author: Narasimha Kulkarni <nakulkar@microsoft.com> Date: Tue Mar 29 15:21:56 2022 +0530 Env var to control downloading to temp path (#1667) * Env var to control downloading to temp path * Implement TempPath method in mockedLCM commit 4360757 Author: Narasimha Kulkarni <nakulkar@microsoft.com> Date: Mon Mar 28 16:09:29 2022 +0530 Refactor STE: Separate JobsAdmin out of STE (#1719) commit 93a3b74 Author: Narasimha Kulkarni <nakulkar@microsoft.com> Date: Thu Mar 24 07:48:09 2022 +0530 Introduce syslogger to be used with STE (#1721) * Introduce syslogger to be used with STE * Fix windows build * Address reviews commit 832fa4c Author: Mohit Sharma <65536214+mohsha-msft@users.noreply.github.com> Date: Thu Mar 24 07:46:15 2022 +0530 Changed timeout to 60m (#1718) commit 1ac90a4 Author: adreed-msft <49764384+adreed-msft@users.noreply.github.com> Date: Wed Mar 16 11:07:56 2022 -0700 Implement OAuth in the modern test framework (#1410) * Configure Azure Pipelines for OAuth on E2E * Handle separate source/destination request lists * Reduce surface area of oauth testing * Update function signatures * Fix panic * Set OAuth info * Fix auth for remove * Fix resume support * Fix objectTarget * Fix CopyToWrongBlobType * Fix StripTopDir * Reduce scale of TestResume_LargeGeneric * Add CPK vars * Add HNS key * Fix test definitions * Add E2E classic account key * Resolve Mohit's comments commit 6e2c8e7 Author: Mohit Sharma <65536214+mohsha-msft@users.noreply.github.com> Date: Wed Mar 16 21:07:10 2022 +0530 Fix error message in local traverser (issue #849) (#1713) * Log the failure to scan local files to help debugging * return error trace as well. Co-authored-by: Adele Reed <adreed@microsoft.com> commit e2673aa Author: Ze Qian Zhang <zezha@microsoft.com> Date: Wed Mar 16 03:39:13 2022 -0700 Dev <- Main after 10.14.1 (#1712) * Fix Invalid Blob Name (#1608) * Revert "Fix Invalid Blob Name (#1608)" (#1644) This reverts commit deac65d. * Fix handling of env variable (#1686) * Added Component Governance Component Detection (#1690) Co-authored-by: Mohit Sharma <65536214+mohsha-msft@users.noreply.github.com> Co-authored-by: siminsavani-msft <77068571+siminsavani-msft@users.noreply.github.com> commit 84bd216 Author: Mohit Sharma <65536214+mohsha-msft@users.noreply.github.com> Date: Wed Mar 16 14:08:31 2022 +0530 MinIO TraceOn in DEBUG mode (#1678) * Added TraceOn in MinIO * Minor Edits * Redesigned * Changes when logger is nil. Passing unit tests. * Scrubbing off unnecessary changes * Removed extra changes commit 7ee54bc Author: Mohit Sharma <65536214+mohsha-msft@users.noreply.github.com> Date: Wed Mar 16 13:29:36 2022 +0530 Updated Dependencies. (#1708) commit f4e5770 Author: Ze Qian Zhang <zezha@microsoft.com> Date: Tue Mar 15 11:01:13 2022 -0700 Merge main back to dev after 10.14 (#1691) * Fix Invalid Blob Name (#1608) * Revert "Fix Invalid Blob Name (#1608)" (#1644) This reverts commit deac65d. * Fix handling of env variable (#1686) * Added Component Governance Component Detection (#1690) Co-authored-by: Mohit Sharma <65536214+mohsha-msft@users.noreply.github.com> Co-authored-by: siminsavani-msft <77068571+siminsavani-msft@users.noreply.github.com>
tiverma-msft
pushed a commit
to tiverma-msft/azure-storage-azcopy
that referenced
this pull request
Apr 19, 2022
* Env var to control downloading to temp path * Implement TempPath method in mockedLCM
tiverma-msft
pushed a commit
to tiverma-msft/azure-storage-azcopy
that referenced
this pull request
Apr 22, 2022
* Env var to control downloading to temp path * Implement TempPath method in mockedLCM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.