Fix some oopsies in the unix properties PR #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
adreed-msft
commented
Jun 1, 2022
adreed-msft
commented
- We didn't clone the metadata map when we were going to modify it for individual blobs, meaning we'd encounter data races, and incorrect properties would be written
- The incorrect seconds value was used for CTime, leading to an invalid value for UnixNano.
| if unixSIP, ok := s.sip.(IUNIXPropertyBearingSourceInfoProvider); ok { | ||
| // Clone the metadata before we write to it, we shouldn't be writing to the same metadata as every other blob. |
There was a problem hiding this comment.
Any unit tests or e2e tests that we could write up for this scenario you think that could have caught this?
There was a problem hiding this comment.
It was my intent to produce some e2e tests after I finish the symlink work that would test the entire scenario.
There was a problem hiding this comment.
@adreed-msft we need to do the same for pageBlob too.
zezha-msft
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.