Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job Manager changes #1820

Merged
merged 4 commits into from
Jun 7, 2022
Merged

Job Manager changes #1820

merged 4 commits into from
Jun 7, 2022

Conversation

Strikerzee
Copy link
Contributor

@Strikerzee Strikerzee commented Jun 2, 2022

NOTE - This PR is a subset of the following PR: #1797

JobMgr Cleanup. (Cherry-picked from personal/nitin/xdatamove)

  • Close all the go routines once job is done.

Fix for Report Handler routine cleanup. (Cherry-picked from personal/nitin/xdatamove)

Memory Leak Fix. (Cherry-picked from personal/nitin/xdatamove)

  • Set the nil to address allocated memory.

  • Fixing some of memory issues.

  • JobMgr is freed without setting channel to nil.

JobMgr Cleanup.

- Close all the go routines once job is done.

Fix for Report Handler routine cleanup.

Remove ChangeLogLevel change.

Memory Leak Fix.

- Set the nil to address allocated memory.

- Fixing some of memory issues.

- JobMgr is freed without setting channel to nil.
@Strikerzee Strikerzee changed the base branch from main to dev June 2, 2022 02:31
@zezha-msft zezha-msft added this to the xdm-integration milestone Jun 2, 2022
Copy link
Member

@nakulkar-msft nakulkar-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace fmt.Print with appropriate log statements

@Strikerzee
Copy link
Contributor Author

Replace fmt.Print with appropriate log statements

@nitin-deamon @mohsha-msft
I believe it resolves this comment as well: #1797 (comment)

Copy link
Contributor

@mohsha-msft mohsha-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated changes! ❤️
LGTM.
Please add all TODOs from your PR in a backlog so we can track them for future releases.

ste/mgr-JobMgr.go Outdated Show resolved Hide resolved
ste/mgr-JobMgr.go Outdated Show resolved Hide resolved
ste/mgr-JobPartMgr.go Show resolved Hide resolved
@Strikerzee Strikerzee merged commit 9908569 into dev Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants