Wait for child process to complete the mount before exit #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as completed the mount
vibhansa-msft
changed the title
gapra-msft
approved these changes
Mar 17, 2023
|
Please take a look at #1088 before merging this PR, thanks. |
Have given some comments on that PR, it does not solve problem where child process does not even mount. |
souravgupta-msft
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1079 Shell returns before daemon process mounts the container and if user tries to bind the mount it leads to inconsistent state. Adding cli flag to wait after demonization to ensure child process has completed the mount.