Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit with non-zero status code if allow_other is used but not enabled in fuse config #1087

Merged
merged 7 commits into from
Mar 21, 2023

Conversation

vibhansa-msft
Copy link
Member

Fix for #1081

@cvvz
Copy link
Contributor

cvvz commented Mar 19, 2023

Please take a look at #1088. I think it should be the right way to solve this kind of problem, instead of handling the -o allow_other option alone.

@vibhansa-msft
Copy link
Member Author

Please take a look at #1088. I think it should be the right way to solve this kind of problem, instead of handling the -o allow_other option alone.

That other PR will not solve this issue as post those changes blobfuse binary will exit with non zero status code but still does not give any hint on what went wrong.

@vibhansa-msft vibhansa-msft merged commit 5e06d43 into main Mar 21, 2023
@cvvz
Copy link
Contributor

cvvz commented Mar 21, 2023

Since this PR has been merged and I'm not the expert of blobfuse V2, so I'm not going to oppose to this pr.

However, I have to say that with #1088, we can sure get the error code and error message, which is directly returned from libfuse.
image

The other concern about this PR is that: if we decide to upgrade libfuse someday and some behavior changed, or if there are some differences from fuse v2 and fuse v3, we may still encounter some problem and have to add more similar changes in blobfuse2 validation logic.

@andyzhangx
Copy link
Contributor

@vibhansa-msft pls hold on releasing any new blobfuse2 version, we are setting up a daily e2e test validation on blobfuse2 main branch, to make sure there is no regression after integration with blob csi driver.

@cvvz
Copy link
Contributor

cvvz commented Mar 21, 2023

@vibhansa-msft Can you test with #1088 again to see if it can solve this issue? I've tested and it can provide error message from libfuse. Please rethink about this PR. Considering the risk I just raised, I'd prefer we solve this problem by #1088, rather than this PR. Thanks

@vibhansa-msft vibhansa-msft deleted the vibhansa/v2/allowotherfailure branch March 22, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Can't mount with -o allow_other on WSL, and blobfuse2 print no error message and errno is 0
5 participants