Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax JSON 1.x #55

Closed
toddysm opened this issue Oct 10, 2016 · 4 comments
Closed

Relax JSON 1.x #55

toddysm opened this issue Oct 10, 2016 · 4 comments

Comments

@toddysm
Copy link

toddysm commented Oct 10, 2016

The library has a hard dependency on the 1.x JSON gem, which breaks newer gems that are using 2.x JSON. Can the dependency be relaxed or removed from the gemspec?
@yaxia
Copy link
Member

yaxia commented Oct 17, 2016

Thanks for your feedback. We are evaluating this requirement and will update to you soon.

@yaxia
Copy link
Member

yaxia commented Oct 31, 2016

We will move to JSON 2.x in a later release, please stay tuned. Thanks.

yaxia added a commit to yaxia/azure-storage-ruby that referenced this issue Nov 25, 2016
@yaxia
* Removed the unnecessary dependencies. This resolves: [Azure#55](Azu…
c631c29 
…re#55), [Azure#67](Azure#67)

* Fixed the issue when checking the content encoding.
* Fixed the wrong "Content-Encoding" value in the test cases.
This was referenced Nov 30, 2016
Closed
Merged
@yaxia
Copy link
Member

yaxia commented Nov 30, 2016

We removed the constrain in 0.11.4. Please take a try. Thanks.

@vinjiang vinjiang closed this as completed Dec 1, 2016
@toddysm
Copy link
Author

toddysm commented Dec 6, 2016

Works for us now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@toddysm @vinjiang @yaxia