changing mqtt %zu to %d for mbed #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/mqtt_client.c
Outdated
| @@ -664,7 +664,7 @@ static void ProcessPublishMessage(MQTT_CLIENT* mqtt_client, uint8_t* initialPos, | |||
| #ifndef NO_LOGGING | |||
| if (mqtt_client->logTrace) | |||
| { | |||
| STRING_sprintf(trace_log, " | PAYLOAD_LEN: %zu", numberOfBytesToBeRead); | |||
| STRING_sprintf(trace_log, " | PAYLOAD_LEN: %d", (int)numberOfBytesToBeRead); | |||
There was a problem hiding this comment.
%d", (int) [](start = 63, length = 10)
why cast? Leaving unsigned %u is better. #Closed
src/mqtt_codec.c
Outdated
| @@ -819,7 +819,7 @@ BUFFER_HANDLE mqtt_codec_publish(QOS_VALUE qosValue, bool duplicateMsg, bool ser | |||
| (void)memcpy(iterator, msgBuffer, buffLen); | |||
| if (trace_log) | |||
| { | |||
| STRING_sprintf(varible_header_log, " | PAYLOAD_LEN: %zu", buffLen); | |||
| STRING_sprintf(varible_header_log, " | PAYLOAD_LEN: %d", (int)buffLen); | |||
There was a problem hiding this comment.
: %d", (int)b [](start = 82, length = 13)
%u #Closed
src/mqtt_message.c
Outdated
| @@ -111,7 +111,7 @@ MQTT_MESSAGE_HANDLE mqttmessage_create(uint16_t packetId, const char* topicName, | |||
| if (result->appPayload.message == NULL) | |||
| { | |||
| /* Codes_SRS_MQTTMESSAGE_07_003: [If any memory allocation fails mqttmessage_create shall free any allocated memory and return NULL.] */ | |||
| LogError("Failure allocating message value of %zu", appMsgLength); | |||
| LogError("Failure allocating message value of %d", (int)appMsgLength); | |||
There was a problem hiding this comment.
%d", (int)app [](start = 70, length = 13)
%u #Closed
ewertons
approved these changes
Jan 11, 2019
bikamani
approved these changes
Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.