Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcile IJobActivator with DI #1917

Closed
mathewc opened this issue Sep 18, 2018 · 5 comments
Closed

Reconcile IJobActivator with DI #1917

mathewc opened this issue Sep 18, 2018 · 5 comments

Comments

@mathewc
Copy link
Member

mathewc commented Sep 18, 2018

When we did the DI work, we didn't reconcile the existing IJobActivator interface with DI. There are patterns that can be used to bridge the gap (e.g. see #1915) however, registration of a custom IJobActivator instance shouldn't be needed. Instead our activation channel should be able to just use the IServiceProvider to dynamically get instances as needed.

@jnevins-gcm
Copy link

Is this (first class DI for functions themselves) this expected for part of initial v2 GA release?

@mathewc
Copy link
Member Author

mathewc commented Sep 21, 2018

No unfortunately, it missed the cutoff. But we'll get it in soon.

@ggirard07
Copy link

@mathewc does the change mean having a static class to host functions is no longer the way to go?
Do we now need to pay attention to Functions object lifetime?

@bryansray
Copy link

This issue shows closed, but I'm not quite seeing if DI is still natively supported? Is there an example of how to do dependency injection that works? I can't seem to get it going.

@Zebusch
Copy link

Zebusch commented Jun 20, 2019

Also can't get it to work. Trying the sample but the constructor for Functions is not being called (which in turn makes all services null when trying to call them from triggered method).

@mathewc - Any comments on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants