Release v1.1.2 - Fix 2 minor bug #26 & #27

[jtracey93]

Overview/Summary

Release v1.1.2 - Fix 2 minor bug #26 & #27

This PR fixes/adds/changes/removes

1. Fixes 🪲 Bug Report - disableTelemetry not being passed into child CARML modules and therefore some telemetry being left enabled #26
2. Fixes 🪲 Bug Report - Creating subscriptions without networking resources causes management group placement and sub tags etc. to not be deployed/created #27

Breaking Changes

None

Testing Evidence

Using

@description('Specifies the location for resources.')
param location string = 'uksouth'

targetScope = 'managementGroup'

module sub001 'main.bicep' = {
  name: 'sub-04122022'
  params: {
    subscriptionAliasEnabled: true
    subscriptionBillingScope: '/providers/Microsoft.Billing/billingAccounts/7690848/enrollmentAccounts/318926'
    subscriptionAliasName: 'sub-test-04122022'
    subscriptionDisplayName: 'sub-test-04122022'
    subscriptionTags: {
      example: 'true'
    }
    subscriptionWorkload: 'Production'
    subscriptionManagementGroupAssociationEnabled: true
    subscriptionManagementGroupId: 'test-lz-vend'
    disableTelemetry: false
    virtualNetworkEnabled: true
    virtualNetworkResourceGroupLockEnabled: false
    virtualNetworkResourceGroupName: 'rsg-plat-04122022'
    virtualNetworkLocation: location
    virtualNetworkName: 'vnet-uks-04122022'
    virtualNetworkAddressSpace: [
      '10.12.34.0/24'
    ]
    virtualNetworkPeeringEnabled: true
    hubNetworkResourceId: '/subscriptions/261c16cc-a6a5-4d50-8e59-b50a4aadbc61/resourceGroups/rsg-lz-vending-testing-hub/providers/Microsoft.Network/virtualHubs/vhub-uks-001'
  }
}

module sub002 'main.bicep' = {
  name: 'sub-04122022-2'
  params: {
    subscriptionAliasEnabled: true
    subscriptionBillingScope: '/providers/Microsoft.Billing/billingAccounts/7690848/enrollmentAccounts/318926'
    subscriptionAliasName: 'sub-test-04122022-2'
    subscriptionDisplayName: 'sub-test-04122022-2'
    subscriptionTags: {
      example: 'true'
    }
    subscriptionWorkload: 'Production'
    subscriptionManagementGroupAssociationEnabled: true
    subscriptionManagementGroupId: 'test-lz-vend'
    disableTelemetry: true
    virtualNetworkEnabled: true
    virtualNetworkResourceGroupLockEnabled: false
    virtualNetworkResourceGroupName: 'rsg-plat-04122022'
    virtualNetworkLocation: location
    virtualNetworkName: 'vnet-uks-04122022-2'
    virtualNetworkAddressSpace: [
      '10.12.35.0/24'
    ]
    virtualNetworkPeeringEnabled: true
    virtualNetworkUseRemoteGateways: false
    hubNetworkResourceId: '/subscriptions/261c16cc-a6a5-4d50-8e59-b50a4aadbc61/resourceGroups/rsg-lz-vending-testing-hub/providers/Microsoft.Network/virtualNetworks/vnet-uks-hub-001'
  }
}

As part of this Pull Request I have

• Read the Contribution Guide and ensured this PR is compliant with the guide
• Checked for duplicate Pull Requests
• Associated it with relevant GitHub Issues
• (ALZ Bicep Core Team Only) Associated it with relevant ADO Items
• Ensured my code/branch is up-to-date with the latest changes in the main branch
• Performed testing and provided evidence.
• Updated one or more of the following tests (if required)
  • Unit
  • Linting
• Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)

[matt-FFFFFF]

LGTM