Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added UDTs for Private and Public DNS zone records and fixed typos in PR template - avm/res/network/dns-zone, avm/res/network/private-dns-zone #1931

Merged
merged 20 commits into from
Jun 5, 2024

Conversation

johnlokerse
Copy link
Contributor

@johnlokerse johnlokerse commented May 14, 2024

Description

This pull request adds user-defined types for the (private and public) DNS zone records. Updated the version.json to 0.3.
Also, fixed some typos in the PR template.

Tagging module owner: @ChrisSidebotham

Pipeline Reference

Pipeline
avm.res.network.dns-zone
avm.res.network.private-dns-zone

Type of Change

  • Update to CI Environment or utilities (Non-module effecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@johnlokerse johnlokerse requested review from a team as code owners May 14, 2024 13:45
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels May 14, 2024
@matebarabas matebarabas changed the title feat: Added UDTs for Private and Public DNS zone records and fixed typos in PR template feat: Added UDTs for Private and Public DNS zone records and fixed typos in PR template - avm/res/network/dns-zone, avm/res/network/private-dns-zone May 21, 2024
@matebarabas matebarabas added Class: Resource Module 📦 This is a resource module and removed Needs: Triage 🔍 Maintainers need to triage still labels May 21, 2024
Copy link
Contributor

@ChrisSidebotham ChrisSidebotham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ChrisSidebotham ChrisSidebotham merged commit f45a5a5 into Azure:main Jun 5, 2024
5 checks passed
@johnlokerse johnlokerse deleted the johnlokerse/udt-dns-zones branch June 10, 2024 09:32
hundredacres pushed a commit to hundredacres/bicep-registry-modules that referenced this pull request Jun 19, 2024
…pos in PR template - `avm/res/network/dns-zone`, `avm/res/network/private-dns-zone` (Azure#1931)

## Description

This pull request adds user-defined types for the (private and public)
DNS zone records. Updated the version.json to 0.3.
Also, fixed some typos in the PR template.

Tagging module owner: @ChrisSidebotham 

## Pipeline Reference

| Pipeline |
| -------- |

|[![avm.res.network.dns-zone](https://github.com/johnlokerse/bicep-registry-modules/actions/workflows/avm.res.network.dns-zone.yml/badge.svg?branch=johnlokerse%2Fudt-dns-zones)](https://github.com/johnlokerse/bicep-registry-modules/actions/workflows/avm.res.network.dns-zone.yml)|

|[![avm.res.network.private-dns-zone](https://github.com/johnlokerse/bicep-registry-modules/actions/workflows/avm.res.network.private-dns-zone.yml/badge.svg?branch=johnlokerse%2Fudt-dns-zones)](https://github.com/johnlokerse/bicep-registry-modules/actions/workflows/avm.res.network.private-dns-zone.yml)|

## Type of Change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module effecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [x] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [x] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->

---------

Co-authored-by: ChrisSidebotham-MSFT <48600046+ChrisSidebotham@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants